Implement project stage four by amirbiron · Pull Request #1343 · amirbiron/CodeBot

amirbiron · 2025-11-04T19:34:00Z

What

הוספתי את המודול החדש resilience.py עם ניהול Retry/Circuit Breaker ומשתני ENV ניתנים לכיוון.
עטפתי מחדש את http_sync.request ו-http_async.request במדיניות הרזיליינס, כולל עדכוני observability ו-emit אירועים.
שדרגתי אינטגרציות (Pastebin, Webhooks, GitHub monitor) ופקודות בוט לעבודה עם ה-API החדש ולתוויות מטריקות.
הרחבתי את metrics.py (קשור לשלב 4) עם מטריקות חדשות למדדי resiliency.
עדכנתי טסטים קיימים והוספתי כיסוי ל-retry/circuit (סינכרוני ואסינכרוני).

Why

שלב 4 דרש רזיליינס מלא מול שירותים חיצוניים ומטריקות שמאפשרות ניטור. הבנייה מחדש מאחדת את כל הניהול לנקודה אחת ומקטינה רעשים זמניים, לצד היכולת לזהות מוקדים בעייתיים (CB פתוח, כמות retries וכו’).

Docs

מומלץ להוסיף עמוד “Outbound Resilience” בתיעוד, עם פירוט ה-ENV, המטריקות החדשות והנחיות הפעלה (ראו הצעת דראפט בהערה המצורפת).

Tests

לא הורצו – אין pytest מותקן בסביבה (ניסיון להריץ python3 -m pytest נכשל).

Note

Adds a resilience layer (retry + circuit breaker) to async/sync HTTP, updates integrations/bot/utils to use it with observability, introduces outbound metrics, aligns required check names (no emojis) across CI/docs, and expands tests.

Resilience & HTTP:
- Add resilience.py with env‑configurable RetryPolicy/CircuitBreaker and helpers (resolve_labels, metrics hooks).
- Overhaul http_async.py and http_sync.py with resilient request(...) (retries, backoff, circuit breaker, observability events/spans) and session instrumentation.
Integrations & Bot:
- Migrate GitHub monitor, Pastebin, webhooks, bot handlers, and utils.FileUtils.download_file to http_async.request(...) with service/endpoint labels.
- Make GitHub backoff delay env‑tunable in github_menu_handler.apply_rate_limit_delay.
Metrics:
- Extend metrics.py with outbound request duration, retry counters, and circuit state/success‑rate gauges.
CI/CD & Templates/Docs:
- Normalize required status contexts (remove emojis) and simplify status reporting in .github/workflows/ci.yml/deploy.yml and PR template/docs.
- Unit test job names changed to Unit Tests (3.11/3.12); add env to minimize backoff during tests.
Tests:
- Update existing tests to new async context API; add retry/circuit behavior tests for async/sync HTTP and adjust stubs to release responses.

^{Written by Cursor Bugbot for commit 12b2cb2. This will update automatically on new commits. Configure here.}

Co-authored-by: amirbiron <amirbiron@gmail.com>

cursor · 2025-11-04T19:34:00Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

github-actions · 2025-11-04T19:34:16Z

🧯 Dangerous deletes guard report

Policy: see .cursorrules — dangerous deletions are blocked unless wrapped safely.

Summary:

Flagged findings (blocking): 0
0
Excluded matches (not blocking): 15
Total matches (all files): 125

Flagged findings (file:line:snippet):
(none)

Excluded matches (by path pattern)

./Dockerfile:34:    rm -rf /var/lib/apt/lists/*
./Dockerfile:76:    rm -rf /var/lib/apt/lists/*
./webapp/static/js/md_preview.bundle.js.map:4:  "sourcesContent": ["// Markdown-it plugin to render GitHub-style task lists; see\n//\n// https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments\n// https://github.com/blog/1825-t … [truncated]
./README.md:778:find . -name "__pycache__" -exec rm -rf {} +
./docs/DOCUMENTATION_GUIDE.md:453:rm -rf _build
./docs/Makefile:24:	rm -rf $(BUILDDIR)
./node_modules/mermaid/dist/chunks/mermaid.core/chunk-KS23V3DP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence  … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequen … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs:1:var r={name:"mermaid",version:"11.12.0",description:"Markdown-ish syntax for generating flowcharts, mindmaps, sequence diagrams, class diagrams, gantt charts, git graph … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm/chunk-2M32CCKP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence d … [truncated]
./node_modules/mermaid/dist/mermaid.min.js:1524:`,"getStyles"),c1e=RQe});var h1e={};dr(h1e,{diagram:()=>NQe});var NQe,f1e=N(()=>{"use strict";$ge();a1e();l1e();u1e();NQe={parser:Fge,db:n1e,renderer:o1e,styles:c1e}});var m1e,g1e=N(()=>{"use  … [truncated]
./node_modules/mermaid/dist/mermaid.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values for tr … [truncated]
./node_modules/mermaid/dist/mermaid.min.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values fo … [truncated]
./node_modules/katex/package.json:153:    "build": "rimraf dist/ && mkdirp dist && cp README.md dist && rollup -c --failAfterWarnings && webpack && node update-sri.js package dist/README.md",
./node_modules/katex/src/fonts/Makefile:139:	rm -rf pfa ff otf ttf woff woff2

github-actions · 2025-11-04T19:35:07Z

⏱️ Performance report

Run: https://github.com/amirbiron/CodeBot/actions/runs/19086270133
Artifact: perf-durations

(No performance test durations collected. Mark tests with @pytest.mark.performance.)

This change defers the import of metrics functions until they are actually needed, improving startup performance and reducing optional dependencies. Co-authored-by: amirbiron <amirbiron@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: amirbiron <amirbiron@gmail.com>

github-actions · 2025-11-04T19:55:27Z

📖 Documentation Preview

The documentation has been built successfully!

📦 Download Documentation Artifacts
🔍 Check the workflow summary for coverage report
📊 Build completed at: Tue, 04 Nov 2025 23:40:09 GMT

To view locally:

Download the artifacts
Extract the zip file
Open index.html in your browser

amirbiron · 2025-11-04T20:30:15Z

@copilot
@cursoragent

הטסט תקוע לא מתקדם,

ומצאתי:

0s
Run actions/github-script@v7
RequestError [HttpError]: Validation Failed
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:9537:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:36187:16), <anonymous>:5:1)
    at async main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:36285:20) {
  status: 422,
  response: {
    url: 'https://api.github.com/repos/amirbiron/CodeBot/statuses/b0723bdaec78795770acad483b5ea51310bd51a2',
    status: 422,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      'content-length': '205',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Tue, 04 Nov 2025 20:27:22 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'github.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-accepted-github-permissions': 'statuses=write',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-api-version-selected': '2022-11-28',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': '5C00:25D557:A639C8:2D16D42:690A61AA',
      'x-ratelimit-limit': '5000',
      'x-ratelimit-remaining': '4946',
      'x-ratelimit-reset': '1762291259',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '54',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Validation Failed',
      errors: "Validation failed: Context doesn't accept 4-byte Unicode",
      documentation_url: 'https://docs.github.com/rest/commits/statuses#create-a-commit-status',
      status: '422'
    }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/amirbiron/CodeBot/statuses/b0723bdaec78795770acad483b5ea51310bd51a2',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'actions/github-script octokit-core.js/5.0.1 Node.js/20.19.5 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"state":"pending","context":"🧪 Unit Tests (3.11)","description":"Job queued/running","target_url":"https://github.com/amirbiron/CodeBot/actions/runs/19081098526"}',
    request: {
      agent: [Agent],
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}
Error: Unhandled error: HttpError: Validation Failed

Copilot · 2025-11-04T20:30:23Z

@amirbiron I've opened a new pull request, #1347, to work on those changes. Once the pull request is ready, I'll request review from you.

amirbiron · 2025-11-04T20:52:00Z

@cursoragent

הטסט תקוע לא מתקדם,

ומצאתי:

0s
Run actions/github-script@v7
RequestError [HttpError]: Validation Failed
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:9537:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:36187:16), <anonymous>:5:1)
    at async main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:36285:20) {
  status: 422,
  response: {
    url: 'https://api.github.com/repos/amirbiron/CodeBot/statuses/b0723bdaec78795770acad483b5ea51310bd51a2',
    status: 422,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      'content-length': '205',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Tue, 04 Nov 2025 20:27:22 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'github.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-accepted-github-permissions': 'statuses=write',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-api-version-selected': '2022-11-28',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': '5C00:25D557:A639C8:2D16D42:690A61AA',
      'x-ratelimit-limit': '5000',
      'x-ratelimit-remaining': '4946',
      'x-ratelimit-reset': '1762291259',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '54',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Validation Failed',
      errors: "Validation failed: Context doesn't accept 4-byte Unicode",
      documentation_url: 'https://docs.github.com/rest/commits/statuses#create-a-commit-status',
      status: '422'
    }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/amirbiron/CodeBot/statuses/b0723bdaec78795770acad483b5ea51310bd51a2',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'actions/github-script octokit-core.js/5.0.1 Node.js/20.19.5 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"state":"pending","context":"🧪 Unit Tests (3.11)","description":"Job queued/running","target_url":"https://github.com/amirbiron/CodeBot/actions/runs/19081098526"}',
    request: {
      agent: [Agent],
      fetch: [Function: proxyFetch],
      hook: [Function: bound bound register]
    }
  }
}
Error: Unhandled error: HttpError: Validation Failed

cursor · 2025-11-04T20:52:05Z

נראה שזה נופל על הסטטוס־API של GitHub בגלל שהערך ב־context מכיל אימוג’י (“🧪 Unit Tests (3.11)”). ה־Statuses API לא מקבל תווים ב־4־בייט, ולכן הקריאה מחזירה 422. כדי לפתור:

עדכן בקובץ ה־workflow את הערכים של context (וגם description אם צריך) כך שיכילו טקסט ASCII בלבד, למשל Unit Tests (3.11) בלי האימוג’י.
הרץ את ה־job מחדש אחרי השינוי; ה־pending status יוגדר בלי השגיאה, והבדיקות יתקדמו כרגיל.

ברגע שה־context נקי מהאימוג’י, הסטטוסים שוב יעבדו.

_{Learn more about Cursor Agents}

…texts (#1347) * Initial plan * Fix: Remove emojis from GitHub status context fields Co-authored-by: amirbiron <215461772+amirbiron@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: amirbiron <215461772+amirbiron@users.noreply.github.com>

This change removes the '🧪' emoji from CI test names in documentation and workflow files. Co-authored-by: amirbiron <amirbiron@gmail.com>

Co-authored-by: amirbiron <amirbiron@gmail.com>

Fix formatting of push event in CI/CD workflow.

Co-authored-by: amirbiron <amirbiron@gmail.com>

Remove unused imports and dummy classes. Improve test clarity by directly testing session creation. Co-authored-by: amirbiron <amirbiron@gmail.com>

amirbiron · 2025-11-04T22:15:25Z

@cursoragent

תקוע המון זמן ככה:


tests/test_cancel_fallbacks.py::test_reminders_cancel_fallback_returns_end PASSED [ 15%]
tests/test_cancel_fallbacks.py::test_main_upload_cancel_fallback_returns_end PASSED [ 15%]
tests/test_chatops_alerts.py::test_alerts_command_shows_recent PASSED    [ 16%]
tests/test_chatops_backoff_commands.py::test_enable_disable_backoff_admin PASSED [ 16%]
tests/test_chatops_backoff_commands.py::test_enable_backoff_non_admin_blocked PASSED [ 16%]

תוכל לבדוק מה הטסט הבא בתור ולהבין למה יש תקיעה?

cursor · 2025-11-04T22:15:32Z

סקרתי את סדר הקבצים בתיקיית tests ובדקתי נקודות בקוד שעלולות לגרום להיתקעות (ריטריי/ביטולים).

הטסט הבא בתור: tests/test_chatops_mvp.py (ואחריו tests/test_chatops_system_and_metrics.py, ואז tests/test_chatops_triage_and_errors.py).
הסיבה הסבירה לתקיעה כרגע היא לא בטסטים עצמם אלא בצעד ה‑Statuses ב‑GitHub: יש נסיון להגדיר context עם אימוג׳י (כמו “🧪 Unit Tests (3.11)”) שה‑Statuses API לא מקבל, מה שגורם לשגיאת 422 ועוצר את ההתקדמות. עדכן את ה‑workflow לציין context ב‑ASCII בלבד (למשל: Unit Tests (3.11)) והרצת ה‑job תתקדם תקין.
אם חוששים מתקיעה בגלל ריטריי אסינכרוני שבולע ביטולים: בקוד הנוכחי ה‑CancelledError לא נבלע אלא נזרק מחדש, כך שביטול טסק יעצור מיד ולא ימשיך בריטריי.

async def _async_sleep_with_backoff(attempt: int, policy: RetryPolicy) -> None:
    delay = compute_backoff_delay(attempt, policy)
    if delay <= 0:
        return
    try:
        await asyncio.sleep(delay)
    except asyncio.CancelledError:
        raise
    except Exception:
        return

מומלץ: להסיר אימוג׳י מכל ה‑contexts/description בהגדרת ה‑statuses ב‑workflow ולהריץ מחדש. אם אחרי התיקון עדיין נראה תקוע סביב ה‑16%, נסה להריץ ממוקד -k chatops_mvp כדי לאשר שהקבוצה הזו רצה מהר.

_{Learn more about Cursor Agents}

cursor · 2025-11-04T22:19:15Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

Co-authored-by: amirbiron <amirbiron@gmail.com>

Refactor: Implement resilient HTTP requests with circuit breakers

58ad0b1

Co-authored-by: amirbiron <amirbiron@gmail.com>

Merge branch 'main' into cursor/implement-project-stage-four-33a3

3c82d80

amirbiron marked this pull request as ready for review November 4, 2025 19:47

cursor Bot reviewed Nov 4, 2025

View reviewed changes

Comment thread resilience.py Outdated

cursoragent and others added 2 commits November 4, 2025 19:51

Refactor: Lazily import metrics functions

a9fcd38

This change defers the import of metrics functions until they are actually needed, improving startup performance and reducing optional dependencies. Co-authored-by: amirbiron <amirbiron@gmail.com>

Merge branch 'main' into cursor/implement-project-stage-four-33a3

c0a8768

chatgpt-codex-connector Bot reviewed Nov 4, 2025

View reviewed changes

Comment thread http_async.py

Fix: Handle asyncio.CancelledError in _async_sleep_with_backoff

b0723bd

Co-authored-by: amirbiron <amirbiron@gmail.com>

Copilot AI mentioned this pull request Nov 4, 2025

Fix GitHub Actions validation errors from emojis in commit status contexts #1347

Merged

Copilot AI and others added 7 commits November 4, 2025 22:55

Refactor: Remove emoji from CI test names

6987b3c

This change removes the '🧪' emoji from CI test names in documentation and workflow files. Co-authored-by: amirbiron <amirbiron@gmail.com>

Merge branch 'main' into cursor/implement-project-stage-four-33a3

9096d94

Refactor: Mock aiohttp session and response for testing

9fd4083

Co-authored-by: amirbiron <amirbiron@gmail.com>

Correct push event formatting in ci.yml

c562a7d

Fix formatting of push event in CI/CD workflow.

Fix: Remove unused webhook trigger from test

7595604

Co-authored-by: amirbiron <amirbiron@gmail.com>

Refactor: Simplify aiohttp session testing

0bf030c

Remove unused imports and dummy classes. Improve test clarity by directly testing session creation. Co-authored-by: amirbiron <amirbiron@gmail.com>

cursoragent and others added 3 commits November 4, 2025 22:31

Test: Skip GitHub API calls in status command tests

72b0dd1

Co-authored-by: amirbiron <amirbiron@gmail.com>

Test: Speed up retries by disabling backoff sleep

ffa7df0

Co-authored-by: amirbiron <amirbiron@gmail.com>

Merge branch 'main' into cursor/implement-project-stage-four-33a3

9cc5cd2

cursoragent and others added 6 commits November 4, 2025 22:51

Test: Disable retries backoff and jitter for predictable tests

3d2aa64

Co-authored-by: amirbiron <amirbiron@gmail.com>

Refactor: Adjust GitHub API rate limit delays and test settings

d15825a

Co-authored-by: amirbiron <amirbiron@gmail.com>

Test: Add max_attempts to retry tests

9f8086a

Co-authored-by: amirbiron <amirbiron@gmail.com>

Test: Disable sleep in retry tests

3fce92d

Co-authored-by: amirbiron <amirbiron@gmail.com>

Merge branch 'main' into cursor/implement-project-stage-four-33a3

12b2cb2

Add pytest-timeout to prevent CI hangs

77d96dd

Co-authored-by: amirbiron <amirbiron@gmail.com>

amirbiron merged commit 81f234a into main Nov 4, 2025
25 checks passed

Conversation

amirbiron commented Nov 4, 2025 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Nov 4, 2025

Uh oh!

github-actions Bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧯 Dangerous deletes guard report

Uh oh!

github-actions Bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏱️ Performance report

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📖 Documentation Preview

Uh oh!

amirbiron commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

amirbiron commented Nov 4, 2025

Uh oh!

cursor Bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amirbiron commented Nov 4, 2025

Uh oh!

cursor Bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amirbiron commented Nov 4, 2025 •

edited by cursor Bot

Loading

github-actions Bot commented Nov 4, 2025 •

edited

Loading

github-actions Bot commented Nov 4, 2025 •

edited

Loading

github-actions Bot commented Nov 4, 2025 •

edited

Loading

cursor Bot commented Nov 4, 2025 •

edited

Loading

cursor Bot commented Nov 4, 2025 •

edited

Loading