Skip to content

Fix GitHub Actions validation errors from emojis in commit status contexts - #1347

Merged
amirbiron merged 2 commits into
cursor/implement-project-stage-four-33a3from
copilot/sub-pr-1343
Nov 4, 2025
Merged

Fix GitHub Actions validation errors from emojis in commit status contexts#1347
amirbiron merged 2 commits into
cursor/implement-project-stage-four-33a3from
copilot/sub-pr-1343

Conversation

Copilot AI commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

GitHub's commit status API rejects emojis in the context field, causing RequestError [HttpError]: Validation Failed that blocks CI/CD pipeline execution.

Changes:

  • Remove emojis from all context fields in github-script status reporting steps
  • Consolidate duplicate status reporters (removed "legacy emoji" and "ASCII" variants)
  • Standardize context names to ASCII-only:
    • 🔍 Code Quality & SecurityCode Quality & Security
    • 🧪 Unit Tests (${ver})Unit Tests (${ver})

Before:

context: '🔍 Code Quality & Security'  # Causes API validation error

After:

context: 'Code Quality & Security'  # Valid ASCII-only context

Reduces workflow file by 154 lines while fixing the validation errors.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Note

Replaces emoji status contexts with ASCII and consolidates duplicate status-report steps in the CI workflow.

  • GitHub Actions (.github/workflows/ci.yml):
    • Code Quality job:
      • Replace emoji context with Code Quality & Security for pending/success/cancelled.
      • Fix failure context from Code Quality to Code Quality & Security.
      • Remove duplicate "legacy emoji" status-report steps.
    • Unit Tests job:
      • Keep only ASCII status contexts: Unit Tests (${ver}) for pending/success/failure/cancelled.
      • Delete redundant emoji-based and duplicate status-report steps.

Written by Cursor Bugbot for commit 2784edb. This will update automatically on new commits. Configure here.

Co-authored-by: amirbiron <215461772+amirbiron@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement project stage four Fix GitHub Actions validation errors from emojis in commit status contexts Nov 4, 2025
Copilot AI requested a review from amirbiron November 4, 2025 20:35
@amirbiron
amirbiron marked this pull request as ready for review November 4, 2025 20:35
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

🧯 Dangerous deletes guard report

Policy: see .cursorrules — dangerous deletions are blocked unless wrapped safely.

Summary:

  • Flagged findings (blocking): 0
    0
  • Excluded matches (not blocking): 15
  • Total matches (all files): 125

Flagged findings (file:line:snippet):
(none)

Excluded matches (by path pattern)
./Dockerfile:34:    rm -rf /var/lib/apt/lists/*
./Dockerfile:76:    rm -rf /var/lib/apt/lists/*
./webapp/static/js/md_preview.bundle.js.map:4:  "sourcesContent": ["// Markdown-it plugin to render GitHub-style task lists; see\n//\n// https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments\n// https://github.com/blog/1825-t … [truncated]
./README.md:778:find . -name "__pycache__" -exec rm -rf {} +
./docs/DOCUMENTATION_GUIDE.md:453:rm -rf _build
./docs/Makefile:24:	rm -rf $(BUILDDIR)
./node_modules/mermaid/dist/chunks/mermaid.core/chunk-KS23V3DP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence  … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequen … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs:1:var r={name:"mermaid",version:"11.12.0",description:"Markdown-ish syntax for generating flowcharts, mindmaps, sequence diagrams, class diagrams, gantt charts, git graph … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm/chunk-2M32CCKP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence d … [truncated]
./node_modules/mermaid/dist/mermaid.min.js:1524:`,"getStyles"),c1e=RQe});var h1e={};dr(h1e,{diagram:()=>NQe});var NQe,f1e=N(()=>{"use strict";$ge();a1e();l1e();u1e();NQe={parser:Fge,db:n1e,renderer:o1e,styles:c1e}});var m1e,g1e=N(()=>{"use  … [truncated]
./node_modules/mermaid/dist/mermaid.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values for tr … [truncated]
./node_modules/mermaid/dist/mermaid.min.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values fo … [truncated]
./node_modules/katex/package.json:153:    "build": "rimraf dist/ && mkdirp dist && cp README.md dist && rollup -c --failAfterWarnings && webpack && node update-sri.js package dist/README.md",
./node_modules/katex/src/fonts/Makefile:139:	rm -rf pfa ff otf ttf woff woff2

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

⏱️ Performance report

(No performance test durations collected. Mark tests with @pytest.mark.performance.)

@amirbiron amirbiron added the perf-light לתיוג בפול ריקווסט בדרפט כדי שידולגו טסטים שמסומנים ככבדים label Nov 4, 2025

@amirbiron amirbiron left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@amirbiron amirbiron left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

נראה ששוב נתקעו טסטים

@amirbiron

Copy link
Copy Markdown
Owner

@copilot
נראה ששוב נתקעו טסטים

Copilot AI commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

@copilot
נראה ששוב נתקעו טסטים

אני צריך עוד מידע כדי לעזור. האם תוכל לשתף:

  1. לינק ל-GitHub Actions run שנתקע?
  2. באיזה שלב הטסטים נתקעים (איזה job ספציפי)?
  3. האם יש הודעת שגיאה ספציפית או שהם פשוט לא מסיימים?

זה יעזור לי להבין אם זו בעיית timeout, טסט ספציפי שתקוע, או משהו אחר.

@amirbiron

Copy link
Copy Markdown
Owner

@copilot Unit Tests (3.11)Waiting for status to be reported — Job queued/running
Unit Tests (3.12)
Unit Tests (3.12)Waiting for status to be reported — Job queued/running

Copilot AI commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

@copilot Unit Tests (3.11)Waiting for status to be reported — Job queued/running
Unit Tests (3.12)
Unit Tests (3.12)Waiting for status to be reported — Job queued/running

הסטטוס "Waiting for status to be reported — Job queued/running" הוא תקין - זה אומר שהטסטים רצים כרגע. ה-workflow מוגדר עם timeout של 30 דקות, אז אם הם באמת תקועים, הם יכשלו אוטומטית.

אם הטסטים לוקחים הרבה זמן, אפשר:

  1. לבדוק ב-Actions tab את הלוג של ה-job כדי לראות איפה הם תקועים
  2. להסתכל על השלב "🧪 Run Tests" - שם תראה אילו טסטים רצים

התיקון שלי (commit 2784edb) פתר את בעיית ה-validation errors. אם הטסטים איטיים או תקועים, זו בעיה אחרת שלא קשורה לשינויים שלי ב-workflow.

@amirbiron
amirbiron merged commit 32c78df into cursor/implement-project-stage-four-33a3 Nov 4, 2025
23 of 30 checks passed
amirbiron added a commit that referenced this pull request Nov 4, 2025
* Refactor: Implement resilient HTTP requests with circuit breakers

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Refactor: Lazily import metrics functions

This change defers the import of metrics functions until they are actually needed, improving startup performance and reducing optional dependencies.

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Fix: Handle asyncio.CancelledError in _async_sleep_with_backoff

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Fix GitHub Actions validation errors from emojis in commit status contexts (#1347)

* Initial plan

* Fix: Remove emojis from GitHub status context fields

Co-authored-by: amirbiron <215461772+amirbiron@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: amirbiron <215461772+amirbiron@users.noreply.github.com>

* Refactor: Remove emoji from CI test names

This change removes the '🧪' emoji from CI test names in documentation and workflow files.

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Refactor: Mock aiohttp session and response for testing

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Correct push event formatting in ci.yml

Fix formatting of push event in CI/CD workflow.

* Fix: Remove unused webhook trigger from test

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Refactor: Simplify aiohttp session testing

Remove unused imports and dummy classes. Improve test clarity by directly testing session creation.

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Test: Skip GitHub API calls in status command tests

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Test: Speed up retries by disabling backoff sleep

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Test: Disable retries backoff and jitter for predictable tests

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Refactor: Adjust GitHub API rate limit delays and test settings

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Test: Add max_attempts to retry tests

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Test: Disable sleep in retry tests

Co-authored-by: amirbiron <amirbiron@gmail.com>

* Add pytest-timeout to prevent CI hangs

Co-authored-by: amirbiron <amirbiron@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: amirbiron <215461772+amirbiron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-light לתיוג בפול ריקווסט בדרפט כדי שידולגו טסטים שמסומנים ככבדים

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants