Specify the units for Mutual Information scores by amrcode · Pull Request #1 · amrcode/scikit-learn

amrcode · 2020-09-23T16:28:46Z

This PR adds documentation to the return values of the mutual-information-score functions to make it clear that the units are based on the natural logarithm. It also indicates how the parameters are related to the mathematical representations.

…19641) Co-authored-by: Alek Lefebvre <alek.lefebvre@mail.mcgill.ca> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

Separate arguments into options and commands, and use setuptools.setup if all the requested commands can / should run without NumPy installed, even if there are options present. This fixes a bug where `setup.py --no-user-site egg_info` wants NumPy to be installed, even though `setup.py egg_info` works fine.

…it-learn#19661)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

…/tests (scikit-learn#19565)

…cikit-learn#19607)

…t-learn#19643) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

…ces (scikit-learn#19571) * Use multi_dot for Hessian and gradient product. np.linalg.multi_dot quickly chooses the best order for the multiplication of three matrices.

)

…earn#19670) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: cinbez <cindyb@lightstone.co.za>

) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

…ata (scikit-learn#19622)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>

….py (scikit-learn#19678)

…cikit-learn#19690)

…1_ratio=0) solutions (scikit-learn#19620)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>

…19528)

…19669)

…earn#19611) Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>

* Fix typo in elastic net docstring. * Use norms more explicitly.

Co-authored-by: Joris Clement <joris.clement@cyren.com>

…learn#20159) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Alihan Zihna <alihanz@gmail.com> Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com> Co-authored-by: naozin555 <37050583+naozin555@users.noreply.github.com> Co-authored-by: Venkatachalam N <venky.yuvy@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>

…sformer` (scikit-learn#20191) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

)

…-learn#19784)

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>

…cikit-learn#20202)

Fix lint issues in doc updates.

…return value doc Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>

Line length adjustment

amrcode force-pushed the specify-units-for-mutual-information-metrics branch from 3e32ad7 to f8a079d Compare October 19, 2020 14:46

AlekLefebvre and others added 29 commits March 10, 2021 11:27

Fix Calibrated classifier cv predictions with pipeline (scikit-learn#…

ad7c316

…19641) Co-authored-by: Alek Lefebvre <alek.lefebvre@mail.mcgill.ca> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

DOC Use term 'black people' instead of 'blacks' in Boston descr (scik…

58af019

…it-learn#19661)

ENH Speedup confusion_matrix (scikit-learn#9843)

5980455

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

BUG Fixes verbose > 2 for grid search (scikit-learn#19659)

6f180d7

TST Do not use cache in test_fetch_openml_iris (scikit-learn#19594)

bfd7b58

TST Change assert from sklearn to pytest style in module linear_model…

5ccfabf

…/tests (scikit-learn#19565)

move kmpp public next to kmpp private (scikit-learn#19666)

579e7de

RFC Make non_negative_factorization call NMF instead of the opposite (s…

15fd026

…cikit-learn#19607)

ENH Raises error in hinge_loss when 'pred_decision' is invalid (sciki…

f4e692c

…t-learn#19643) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

MNT Remove absolute imports (scikit-learn#19668)

e3e4a77

ENH Optimize dot product order for LogisticRegression for dense matri…

0c74b8b

…ces (scikit-learn#19571) * Use multi_dot for Hessian and gradient product. np.linalg.multi_dot quickly chooses the best order for the multiplication of three matrices.

DOC Fix typo in plot_multi_metric_evaluation example (scikit-learn#19675

95c3c76

)

ENH Deprecated the default random_state=0 in randomized_svd (scikit-l…

77e998d

…earn#19670) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: cinbez <cindyb@lightstone.co.za>

MNT Fix error message for Minkowski metric parameter (scikit-learn#19671

ac6dea5

) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

FIX RuntimeWarning by dividing by zero in test_iforest_with_uniform_d…

302106b

…ata (scikit-learn#19622)

ENH Adds _num_features for array-likes (scikit-learn#19633)

d996eaf

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>

TST Change assert from sklearn to pytest style in tests/test_pipeline…

edc4f15

….py (scikit-learn#19678)

FIX RuntimeWarning division by zero in check_classifiers_one_label (s…

b7b510f

…cikit-learn#19690)

TST Add a test to check the consistency of the Ridge and ElasticNet(l…

fcf4740

…1_ratio=0) solutions (scikit-learn#19620)

[MRG] Fix documentation for russelrao formula (scikit-learn#19695)

36e4358

ENH Add periodic extrapolation to SplineTransformer (scikit-learn#19483)

95b7c68

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>

CI Use conda instead of pip to install anaconda-client (scikit-learn#…

edc6995

…19528)

MAINT Python 3.9 in badge on README.rst (scikit-learn#19702)

9a186a5

DOC Added utils.gen_batches in documentation (scikit-learn#19688)

04f84c6

ENH Better error for corrupted files in fetch_kddcup99 (scikit-learn#…

2e7009b

…19669)

MNT move PolynomialFeatures from _data.py to _polynomial.py (scikit-l…

ca9618c

…earn#19611) Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>

Fix typo in elastic net docstring. (scikit-learn#19711)

0d7d46f

* Fix typo in elastic net docstring. * Use norms more explicitly.

DOC Correct scorer documentation (scikit-learn#19720)

bf4049c

Co-authored-by: Joris Clement <joris.clement@cyren.com>

thomasjpfan and others added 29 commits June 3, 2021 14:28

FIX Uses points instead of pixels in plot_tree (scikit-learn#20023)

3a23e26

MNT n_features_in through the multiclass module (scikit-learn#20193)

6bfaced

CI Removes python 3.6 builds from wheel building (scikit-learn#20184)

1038024

FIX Fix typo in error message in fetch_openml (scikit-learn#20201)

95f5fb4

FIX Fix error when using Calibrated with Voting (scikit-learn#20087)

7b965c7

FIX Fix RandomForestRegressor doesn't accept max_samples=1.0 (scikit-…

a1a6b3a

…learn#20159) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

TST Replace assert_warns from decomposition/tests (scikit-learn#20214)

9884ccd

TST check n_features_in_ in pipeline module (scikit-learn#20192)

800aee6

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@gmail.com>

Allow n_knots=None if knots are explicitly specified in `SplineTran…

7781256

…sformer` (scikit-learn#20191) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>

FIX make check_complex_data deterministic (scikit-learn#20221)

673625b

TST test_fit_docstring_attributes include properties (scikit-learn#20190

b15e312

)

FIX Uses the color max for colormap in ConfusionMatrixDisplay (scikit…

7f30867

…-learn#19784)

STY Changing .format method to f-string formatting (scikit-learn#20215)

5c3cb6b

[MRG] Listed valid metrics in neighbors.rst (scikit-learn#19379)

c53d33e

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>

DOC Document n_features_in_ in cluster (scikit-learn#20228)

45fc4b7

TST make sure to test SearchCV on both classification and regression (s…

a253826

…cikit-learn#20202)

FIX Do not reset for non-fit in multiclass (scikit-learn#20205)

007da8d

DOC add n_features_in_ in the documentation (scikit-learn#20236)

1cd282d

Update _supervised.py

bf380eb

Update _supervised.py

7421170

Fix lint issues in doc updates.

Update sklearn/metrics/cluster/_supervised.py to add a period in the …

7cb0dbe

…return value doc Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>

Updates from review

14df87f

Fix line lengths

6c1c787

Update _supervised.py

b6e1275

Line length adjustment

Remove trailing whitespace

85aa9ec

Update math notation

e8ff404

Fix line lengths

bdc8ba9

Remove trailing whitespace

26e2064

amrcode force-pushed the specify-units-for-mutual-information-metrics branch from 349ceb7 to 26e2064 Compare June 11, 2021 12:59

Navigation Menu

Specify the units for Mutual Information scores - #1

Specify the units for Mutual Information scores#1
amrcode wants to merge 478 commits into
masterfrom
specify-units-for-mutual-information-metrics

amrcode commented Sep 23, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

amrcode commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

amrcode commented Sep 23, 2020 •

edited

Loading