Roll playbook explanation feedback choices back to previous values #1521
Conversation
There was a problem hiding this comment.
I am hesitant that this is the correct fix.. and that using a 4 in the failing test would not be the more correct solution. VSCode sends possible values 0, 1, 2 or 3 for different user interactions.
In the meantime I'll submit a PR to ansible-wisdom-testing accordingly and we can choose which PR to merge later...
Looks like we'll need https://github.com/ansible/ansible-wisdom-testing/pull/855 merged/corrected first.
Unfortunately I think we'll need @goneri to confirm.
|
@goneri @mabashian I created a PR to fix the tests based on the regeneration of the client code used by the tests. I was hoping to be able to push it into the existing PR.. but failed (I think there's a setting somewhere to allow others to contribute to existing PRs.. but my memory is a little hazzy). I've asked Goneri if he can cherry-pick it into his PR. |
|
Closing as a duplication of #1523 😿 Sorry @mabashian your fix is the same; but I consider @goneri to be the "source of truth" for Playbook Explanation code. Nothing personal. |
Tssss, I closed mine. I was not paying attention and missed this PR. Thank you @mabashian for the fix! |
|
This PR does not need a corresponding Jira item.
Description
There's a test downstream that's failing and I think it's due to this change that came in here: b2e04ee#diff-8b84a8269462c15e4258d8fc31d38ef8e231b71ddfd4e6155f3c705999e7d351L300-L302. I'm rolling that change back to see if we can get the tests happy.
Testing
Steps to test
Scenarios tested
Production deployment