Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaybookExplanationFeedback: do not accept action == 3 #1523

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Feb 5, 2025

Partial revert of b2e04ee to be sure we don't accept an PlaybookExplanationFeedback event when action == 3 and fix the name
of the actions in the OpenAPI schema.

Partial revert of b2e04ee to be sure we don't accept an action == 3 and fix the name
of the actions in the OpenAPI schema.
@goneri goneri requested review from ldjebran and manstis February 5, 2025 16:41
@manstis
Copy link
Contributor

manstis commented Feb 5, 2025

This is a duplication of #1521

Closing @mabashian (although the fix is the same) 😿

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goneri goneri closed this Feb 5, 2025
@goneri
Copy link
Contributor Author

goneri commented Feb 5, 2025

Sorry, I missed that part. I just reopened @mabashian's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants