fix: flaky Stripe test timeouts in payment-details.spec.ts#1594
Open
ethrealSpectre wants to merge 1 commit intoantiwork:mainfrom
Open
fix: flaky Stripe test timeouts in payment-details.spec.ts#1594ethrealSpectre wants to merge 1 commit intoantiwork:mainfrom
ethrealSpectre wants to merge 1 commit intoantiwork:mainfrom
Conversation
Author
|
@nyomanjyotisa PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1531
Test
e2e/tests/settings/administrator/payment-details.spec.ts:22:3 › Company administrator settings - payment details › allows connecting a bank account
https://github.com/antiwork/flexile/actions/runs/20915820205/job/60089005090#step:12:270
Problem
The test
allows connecting a bank accountwas failing in CI with a 60s timeout. The locatorgetByLabel("Test Institution")was stuck waiting for an element that does not exist in the current Stripe test mode UI.Solution
timeout: 60000to Stripe iframe assertions to handle slow loading in CI.page.goto("/settings/administrator/billing").Screenshot
AI Disclosure
I have used Opus 4.5 to understand issue.