Skip to content

fix: flaky Stripe test timeouts in payment-details.spec.ts #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethrealSpectre wants to merge 1 commit into from
+30 −14
Closed

fix: flaky Stripe test timeouts in payment-details.spec.ts #1594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions e2e/tests/settings/administrator/payment-details.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,35 @@ test.describe("Company administrator settings - payment details", () => {
};

test("allows connecting a bank account", async ({ page }) => {
// Extend timeout for slow environments (Stripe iframe loading)
test.setTimeout(180000);
const { company } = await companiesFactory.create({ stripeCustomerId: null }, { withoutBankAccount: true });
const { administrator } = await companyAdministratorsFactory.create({ companyId: company.id });
const adminUser = await db.query.users.findFirst({ where: eq(users.id, administrator.userId) }).then(takeOrThrow);

await login(page, adminUser);
await page.getByRole("link", { name: "Settings" }).click();
await page.getByRole("link", { name: "Billing" }).click();
await page.goto("/settings/administrator/billing");

await expect(
page.getByText("We'll use this account to debit contractor payments and our monthly fee"),
).toBeVisible();
await expect(page.getByText("Payments to contractors may take up to 10 business days to process.")).toBeVisible();
await expect(page.getByText("We'll use this account to debit contractor payments and our monthly fee")).toBeVisible(
{ timeout: 60000 },
);
await expect(page.getByText("Payments to contractors may take up to 10 business days to process.")).toBeVisible({
timeout: 60000,
});
await page.getByRole("button", { name: "Link your bank account" }).click();

const stripePaymentFrame = page.frameLocator("[src^='https://js.stripe.com/v3/elements-inner-payment']");
const stripeBankFrame = page.frameLocator("[src^='https://js.stripe.com/v3/linked-accounts-inner']");

await withinModal(
async () => {
await stripePaymentFrame.getByLabel("Test Institution").click();
// Use search to find the test bank reliably (Back to stripePaymentFrame, reliable locator)
const searchInput = stripePaymentFrame.getByPlaceholder(/Search/iu);
await expect(searchInput).toBeVisible({ timeout: 60000 });
await searchInput.fill("Test");
const bankOption = stripePaymentFrame.getByText("Test (Non-OAuth)");
await expect(bankOption).toBeVisible({ timeout: 60000 });
await bankOption.click();
await stripeBankFrame.getByTestId("agree-button").click();
await stripeBankFrame.getByTestId("success").click();
await stripeBankFrame.getByTestId("select-button").click();
Expand All @@ -62,7 +71,13 @@ test.describe("Company administrator settings - payment details", () => {
await page.getByRole("button", { name: "Edit" }).click();
await withinModal(
async () => {
await stripePaymentFrame.getByLabel("Test Institution").click();
// Use search to find the test bank reliably (Back to stripePaymentFrame, reliable locator)
const searchInput = stripePaymentFrame.getByPlaceholder(/Search/iu);
await expect(searchInput).toBeVisible({ timeout: 60000 });
await searchInput.fill("Test");
const bankOption = stripePaymentFrame.getByText("Test (Non-OAuth)");
await expect(bankOption).toBeVisible({ timeout: 60000 });
await bankOption.click();
await stripeBankFrame.getByTestId("agree-button").click();
await stripeBankFrame.getByTestId("high balance").click();
await stripeBankFrame.getByTestId("select-button").click();
Expand All @@ -84,17 +99,18 @@ test.describe("Company administrator settings - payment details", () => {
});

test("allows connecting a bank account via microdeposits (amounts or descriptor code)", async ({ page }) => {
// Extend timeout for slow environments (Stripe iframe loading)
test.setTimeout(180000);
const { company } = await companiesFactory.create({ stripeCustomerId: null }, { withoutBankAccount: true });
const { administrator } = await companyAdministratorsFactory.create({ companyId: company.id });
const adminUser = await db.query.users.findFirst({ where: eq(users.id, administrator.userId) }).then(takeOrThrow);

await login(page, adminUser);
await page.getByRole("link", { name: "Settings" }).click();
await page.getByRole("link", { name: "Billing" }).click();
await page.goto("/settings/administrator/billing");

await expect(
page.getByText("We'll use this account to debit contractor payments and our monthly fee"),
).toBeVisible();
await expect(page.getByText("We'll use this account to debit contractor payments and our monthly fee")).toBeVisible(
{ timeout: 60000 },
);

await page.getByRole("button", { name: "Link your bank account" }).click();

Expand All @@ -105,7 +121,7 @@ test.describe("Company administrator settings - payment details", () => {
.getByRole("button", { name: "Enter bank details manually" })
.click();
const stripeBankFrame = page.frameLocator("[src^='https://js.stripe.com/v3/linked-accounts-inner']");
await expect(stripeBankFrame.getByLabel("Routing number")).toBeVisible();
await expect(stripeBankFrame.getByLabel("Routing number")).toBeVisible({ timeout: 60000 });
await stripeBankFrame.getByTestId("manualEntry-routingNumber-input").fill("110000000");
await stripeBankFrame.getByTestId("manualEntry-accountNumber-input").fill("000123456789");
await stripeBankFrame.getByTestId("manualEntry-confirmAccountNumber-input").fill("000123456789");
Expand Down