Closed
Conversation
38d14f7 to
80aed37
Compare
BufReader for std::io::Read
80aed37 to
56e1268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Readerimpl,BufReaderwhich addsReadersupport for anystd::io::Read.The implementation is generally what one would expect from a buffered reader implementation. The key nuance to pay attention to is the
as_trusted_forimplementation. Specifically,BufReader'sTrustedimplementation uses the following enum:This type captures two possible scenarios when requesting a trusted window:
In the first case, we can provide a
TrustedSliceReader, which achieves the desired trusted semantics where bounds checks are eliminated, and is very performant.In the second case, we provide a
BufReaderMut, which effectively acts as a typical non-trustedBufReader.An alternative implementation could reallocate the buffer to accomodate the requested window size, but this route provides simplicity, predictability, and user-tuneability. In particular, rather than implicitly reallocating on behalf of the user, one may simply tune capacity for a specific use case.
See #53 for a longer discussion on these points.
Closes #50