-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recent runs duration chart. #46504
Add recent runs duration chart. #46504
Conversation
2091a22
to
f1a3349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this as a good start. But we'll need to do auto refresh and improve the general design of it (accessibility, styling, the space the axis labels take up)
Thanks @bbovenzi , I suppose a very similar overview page will be present for each task too with recent failed task instances, task duration chart etc, as per the design. http://localhost:8000/webapp/dags/tutorial_taskflow_api/tasks/load |
Yes, eventually we want to do a lot more with these dashboard views on the homepage and on a Dag or Task. What were you trying to link here? |
The link was to a sample task details page which now only has task instances and events tab. My understanding from the designs is that there will be a overview page for a task similar to dag page. The task duration chart was useful with median plot and it will be good to have it somewhere in Airflow 3 too. |
* Initial commit for dag run duration chart. * Sort by start_date for recent runs. * Add simple grid layout and border as per design. * Use theme color for queued state.
This uses the API to get recent 14 dag runs to plot the chart along with average of the run and queued duration as annotations. The size is 1/3 since there will be 2 more for success/failed rate and grouped durations as per design. This is for initial implementation and might not completely cover all use cases like Airflow 2 but can be taken up in subsequent PRs or separate issues for them as below. If approved a similar overview page can be created for task page as well in another PR for task duration.
Notes to self and review
stateColor.ts
was removed. What is the recommended way to show color based on state for a given theme?