Update create token apis in simple auth manager #48498
Merged
+155
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
vincbeck
force-pushed
the
vincbeck/token_api
branch
2 times, most recently
from
6c15c58 to
0c5ec30
Compare
jason810496
reviewed
Mar 28, 2025
airflow-core/src/airflow/api_fastapi/auth/managers/simple/services/login.py
Show resolved
Hide resolved
vincbeck
force-pushed
the
vincbeck/token_api
branch
from
0c5ec30 to
1d20e78
Compare
jason810496
approved these changes
Mar 28, 2025
airflow-core/src/airflow/api_fastapi/auth/managers/simple/routes/login.py
Show resolved
Hide resolved
vincbeck
force-pushed
the
vincbeck/token_api
branch
from
1d20e78 to
0f76c5c
Compare
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
amolsr
pushed a commit
to amolsr/airflow
that referenced
this pull request
Apr 2, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the documentation I realized something was missing in simple auth manager. We need to have an API to generate a token when
[core] simple_auth_manager_all_adminsisTrue. The routeGET /auth/tokenin simple auth manager currently logs in the user but we need to have both:I also renamed
jwt_tokenkey from the API responses toaccess_tokento follow standards.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.