Add failure-path and serialization tests for StepFunctionsExecutionCompleteTrigger - #72570
Merged
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
bingqin2
marked this pull request as ready for review
September 6, 2026 03:11
vincbeck
approved these changes
Sep 9, 2026
…mpleteTrigger The region_name fix originally proposed in this PR landed via apache#72625. This adds the remaining coverage: the error TriggerEvent path, verify/botocore_config serialization, pruning of unset hook parameters, and the region_name docstring.
bingqin2
force-pushed
the
add-step-function-trigger-tests
branch
from
September 9, 2026 16:18
a8360a7 to
9b2bb19
Compare
Contributor
Author
|
Thanks for the approval @vincbeck. Since the same fix landed via #72625 while this one was waiting, I have rebased and re-scoped this PR to what is still missing after that merge: the trigger's failure-path test, serialization tests for |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…mpleteTrigger (apache#72570) The region_name fix originally proposed in this PR landed via apache#72625. This adds the remaining coverage: the error TriggerEvent path, verify/botocore_config serialization, pruning of unset hook parameters, and the region_name docstring.
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
…mpleteTrigger (apache#72570) The region_name fix originally proposed in this PR landed via apache#72625. This adds the remaining coverage: the error TriggerEvent path, verify/botocore_config serialization, pruning of unset hook parameters, and the region_name docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
region_namefix originally proposed here was merged in the meantime via #72625, so this PR is re-scoped to the parts that PR did not cover:test_run_failure: the trigger's error path, i.e.async_waitraisingAirflowExceptionyields aTriggerEventwithstatus="error", the message, and the execution ARNtest_serialization_with_verify_and_botocore_config:verifyandbotocore_configround-trip throughserialize()test_serialization_omits_unset_hook_params:region_name,verify, andbotocore_configare pruned from the serialized kwargs when not set; before Fix region_name being ignored by the Step Functions execution trigger #72625 the trigger always serializedregion_name, even asNoneregion_nameparameter in the trigger docstringThe tests merged in #72625 are left unchanged; these are additive.
related: #72625
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Fable 5.1) following the guidelines. I reviewed and understand all changes; the tests were run locally.
🤖 Generated with Claude Code