Fix region_name being ignored by the Step Functions execution trigger - #72625
Merged
vincbeck merged 2 commits intoSep 9, 2026
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
rjgoyln
reviewed
Sep 8, 2026
rjgoyln
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall! Verified the fix locally and confirmed it is correct and minimal. The relevant tests and ruff checks are clean. Just my thoughts — two small nits below. Feel free to resolve if you think otherwise.
StepFunctionsExecutionCompleteTrigger accepted region_name but only put it into serialized_fields without forwarding it to AwsBaseWaiterTrigger, so self.region_name stayed None and the deferred waiter always polled Step Functions in the default region instead of the one the operator was configured with. The base class already serializes region_name itself, so the serialized_fields entry was redundant on top of being inert. Also adds the previously missing dedicated test module for the trigger (tracked in the OVERLOOKED_TESTS allowlist), including a regression test that fails without this fix. Claude-Session: https://claude.ai/code/session_01QL3YuSRJuK6WpZGc4jMjd1
The patched get_async_conn is the method, so the async context manager lives on its return value; setting __aenter__ on the mock itself was a no-op that passed only because AsyncMock auto-creates the manager.
nandeshkanagaraju
force-pushed
the
add-step-function-trigger-tests
branch
from
September 8, 2026 18:04
acc5052 to
ea19177
Compare
vincbeck
approved these changes
Sep 9, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
bingqin2
added a commit
to bingqin2/airflow
that referenced
this pull request
Sep 9, 2026
…mpleteTrigger The region_name fix originally proposed in this PR landed via apache#72625. This adds the remaining coverage: the error TriggerEvent path, verify/botocore_config serialization, pruning of unset hook parameters, and the region_name docstring.
1 task
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…apache#72625) StepFunctionsExecutionCompleteTrigger accepted region_name but only put it into serialized_fields without forwarding it to AwsBaseWaiterTrigger, so self.region_name stayed None and the deferred waiter always polled Step Functions in the default region instead of the one the operator was configured with. The base class already serializes region_name itself, so the serialized_fields entry was redundant on top of being inert. Also adds the previously missing dedicated test module for the trigger (tracked in the OVERLOOKED_TESTS allowlist), including a regression test that fails without this fix.
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…mpleteTrigger (apache#72570) The region_name fix originally proposed in this PR landed via apache#72625. This adds the remaining coverage: the error TriggerEvent path, verify/botocore_config serialization, pruning of unset hook parameters, and the region_name docstring.
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
…mpleteTrigger (apache#72570) The region_name fix originally proposed in this PR landed via apache#72625. This adds the remaining coverage: the error TriggerEvent path, verify/botocore_config serialization, pruning of unset hook parameters, and the region_name docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StepFunctionsExecutionCompleteTrigger accepted region_name but only put it into serialized_fields without forwarding it to AwsBaseWaiterTrigger, so self.region_name stayed None and the deferred waiter always polled Step Functions in the default region instead of the one the operator was configured with. The base class already serializes region_name itself, so the serialized_fields entry was redundant on top of being inert.
Also adds the previously missing dedicated test module for the trigger (tracked in the OVERLOOKED_TESTS allowlist).
test_hook_forwards_connection_configis the regression test for this fix — it is the one that fails without the production change;test_serializationandtest_run_successare there for module coverage and pass either way.Claude-Session: https://claude.ai/code/session_01QL3YuSRJuK6WpZGc4jMjd1
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines