Skip to content

Honour dag_ignore_file_syntax in Task SDK and example plugin loading - #72802

Closed
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-sdk-plugins-ignore-file-syntax
Closed

FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-sdk-plugins-ignore-file-syntax

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • Move find_path_from_directory to shared module_loading library #60114 moved find_path_from_directory into the shared module_loading library, where the ignore syntax defaults to a hard-coded glob. To keep the old behaviour, it made _load_plugins_from_plugin_directory in airflow-core read [core] dag_ignore_file_syntax and pass it to both the plugins folder call and the example plugins folder call.
  • Move over plugins manager to a shared library #59956 then moved _load_plugins_from_plugin_directory into shared/plugins_manager but carried over only half of that change: the plugins folder call gets ignore_file_syntax, while the example plugins call still uses the hard-coded default.
  • Move over plugins manager to a shared library #59956 also left the two wrappers calling the function with different arguments. airflow.plugins_manager passes ignore_file_syntax but airflow.sdk.plugins_manager does not.

How

  • Read dag_ignore_file_syntax in the Task SDK wrapper and pass it to _load_plugins_from_plugin_directory.
  • Pass ignore_file_syntax to the example plugins find_path_from_directory call in the shared library.

Verification

  • uv run --project task-sdk pytest task-sdk/tests/task_sdk/test_plugins_manager.py
  • uv run --project shared/plugins_manager pytest shared/plugins_manager/tests/plugins_manager/test_plugins_manager.py

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@FrankYang0529
FrankYang0529 marked this pull request as ready for review September 9, 2026 13:43
Signed-off-by: PoAn Yang <payang@apache.org>
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @FrankYang0529 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants