Honour dag_ignore_file_syntax in Task SDK and example plugin loading - #72802
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
5cedbc5 to
dfa9d04
Compare
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
find_path_from_directoryinto the sharedmodule_loadinglibrary, where the ignore syntax defaults to a hard-codedglob. To keep the old behaviour, it made_load_plugins_from_plugin_directoryin airflow-core read[core] dag_ignore_file_syntaxand pass it to both the plugins folder call and the example plugins folder call._load_plugins_from_plugin_directoryintoshared/plugins_managerbut carried over only half of that change: the plugins folder call getsignore_file_syntax, while the example plugins call still uses the hard-coded default.airflow.plugins_managerpassesignore_file_syntaxbutairflow.sdk.plugins_managerdoes not.How
dag_ignore_file_syntaxin the Task SDK wrapper and pass it to_load_plugins_from_plugin_directory.ignore_file_syntaxto the example pluginsfind_path_from_directorycall in the shared library.Verification
uv run --project task-sdk pytest task-sdk/tests/task_sdk/test_plugins_manager.pyuv run --project shared/plugins_manager pytest shared/plugins_manager/tests/plugins_manager/test_plugins_manager.pyWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.