Fix env var names in airflow config list for dotted and team sections - #73136
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
airflow config listprints a# Variable:line for each option when--include-env-varsor--defaultsis set.providers.odbc), Airflow readsAIRFLOW__PROVIDERS_ODBC__ALLOW_DRIVER_IN_EXTRA, but the line showedAIRFLOW__PROVIDERS.ODBC__ALLOW_DRIVER_IN_EXTRA. Setting that variable has no effect. The Setting Configuration Options page says to replace a dot in the section name with an underscore.[team_a=celery], Airflow readsAIRFLOW__TEAM_A___CELERY__WORKER_CONCURRENCY, but the line showedAIRFLOW__TEAM_A=CELERY__WORKER_CONCURRENCY. The Multi-Team page documents theAIRFLOW__{TEAM}___{SECTION}__{KEY}format.How
_write_option_headernow gets the name from_env_var_name, the method the parser uses to read environment variables.=and passed asteam_name.Verification
uv run --frozen --project shared/configuration pytest shared/configuration/testsIts output is:
airflow config list --defaultsprints and set it for the command that reads the option back.On the main branch, the setting doesn't take effect, so reading configuration fallbacks to default value:
On this branch, it shows correct variable and the value takes effect:
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.