Minor: Fix ArrayDataBuilder::build_unchecked docs #7103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Feb 10, 2025
| @@ -1929,7 +1929,7 @@ impl ArrayDataBuilder { | |||
|
|
|||
| /// Creates an array data, without any validation | |||
| /// | |||
| /// Note: This is shorthand for `self.with_skip_validation(true).build()` | |||
| /// Note: This is shorthand for `self.skip_validation(true).build().unwrap()` | |||
There was a problem hiding this comment.
Thoughts on making it a doctest so we catch it via tests?
There was a problem hiding this comment.
That would be great! Perhaps as a follow on PR
There was a problem hiding this comment.
@gstvg any chance you have some time to make a PR with a doc example?
There was a problem hiding this comment.
I opened #7139 to make it a doctest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Docs only