Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add doctest to ArrayDataBuilder::build_unchecked #7139

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

gstvg
Copy link
Contributor

@gstvg gstvg commented Feb 15, 2025

Which issue does this PR close?

Follow on to #7103

Rationale for this change

As suggested by @Jefffrey in #7103 (comment), making the code block into a doctest would catch any future error in tests

What changes are included in this PR?

Transform the code block into a doctest

Are there any user-facing changes?

Docs only

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 15, 2025
@gstvg
Copy link
Contributor Author

gstvg commented Feb 15, 2025

Render as:

image

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gstvg ❤️

@alamb alamb merged commit 38d6e69 into apache:main Feb 16, 2025
26 checks passed
friendlymatthew pushed a commit to friendlymatthew/arrow-rs that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants