GH-46116: [C++] Implement IPC directory in Meson #46117
Conversation
|
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
from
d40cf91 to
2d82836
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 2d82836 Submitted crossbow builds: ursacomputing/crossbow @ actions-b6ec55a3f8
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
from
2d82836 to
ec6ec9d
Compare
|
@github-actions crossbow submit *meson |
|
Revision: ec6ec9d Submitted crossbow builds: ursacomputing/crossbow @ actions-aa4eee06df
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
from
ec6ec9d to
f0787a9
Compare
|
@github-actions crossbow submit *meson |
|
Revision: f0787a9 Submitted crossbow builds: ursacomputing/crossbow @ actions-1c051e7123
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
2 times, most recently
from
2f5c8f4 to
7089aad
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 7089aad Submitted crossbow builds: ursacomputing/crossbow @ actions-7e9e31afdb
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
from
7089aad to
905f7ab
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 905f7ab Submitted crossbow builds: ursacomputing/crossbow @ actions-97530cc498
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
3 times, most recently
from
49fa45c to
666e434
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 666e434 Submitted crossbow builds: ursacomputing/crossbow @ actions-c45e03e79f
|
WillAyd
force-pushed
the
meson-ipc-directory
branch
from
666e434 to
e6c435f
Compare
|
@github-actions crossbow submit *meson |
|
Revision: e6c435f Submitted crossbow builds: ursacomputing/crossbow @ actions-9cd023503a
|
|
@kou this is another one that will unlock some of the remaining follow ups. Let me know what you think! |
cpp/src/arrow/ipc/meson.build
Outdated
| if needs_integration | ||
| # TODO: The CMake configuration would add these executables | ||
| # to an arrow-integration target, which is in turn | ||
| # used by arrow-all. The targets are modified, but not | ||
| # used within Arrow C++ (?) - do we need to replicate that here? | ||
| endif |
There was a problem hiding this comment.
We don't need to replicate with Meson.
| if meson.version() < '1.8.0' | ||
| error( | ||
| ' Meson >= 1.8.0 is required for fuzzing support, found @0@'.format( | ||
| meson.version(), | ||
| ), | ||
| ) | ||
| endif |
There was a problem hiding this comment.
We need Meson 1.8.0 or later for -Db_sanitize=fuzzer, right?
There was a problem hiding this comment.
That's correct. 1.8 introduced changes to what b_sanitize accepts as arguments
https://mesonbuild.com/Release-notes-for-1-8-0.html#changes-to-the-b_sanitize-option
WillAyd
force-pushed
the
meson-ipc-directory
branch
from
e6c435f to
965e393
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 965e393 Submitted crossbow builds: ursacomputing/crossbow @ actions-9f2a5e6fff
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4bbc851. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Continues adding support for the Meson build system
What changes are included in this PR?
This adds the ipc directory and adds options for different compression algorithms. The algorithms themselves will raise an error if turned on however, as they need to be enabled in subsequent PRs
Are these changes tested?
Yes
Are there any user-facing changes?
No