Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI assorted fixes #9381

Merged
merged 2 commits into from
Jul 15, 2024
Merged

UI assorted fixes #9381

merged 2 commits into from
Jul 15, 2024

Conversation

rohityadavcloud
Copy link
Member

@rohityadavcloud rohityadavcloud commented Jul 12, 2024

UI fixes to address missing useful columns and fixes copy console button.

Remove unnecessary copy button on info card that looks congested and confusing.

Fixes #9368

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Makes login related config param to be consistent with the original
`loginFooter`. Group them together.

Signed-off-by: Rohit Yadav <[email protected]>
This brings in related buttons across some infra views and new columns
which are missing. Also fixes the copy console URL issue on some
browsers.

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

looks generally good, will test in FF and Chrome.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.27%. Comparing base (32cc1d4) to head (176f213).

❗ There is a different number of reports uploaded between BASE (32cc1d4) and HEAD (176f213). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (32cc1d4) HEAD (176f213)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #9381       +/-   ##
============================================
- Coverage     15.07%   4.27%   -10.81%     
============================================
  Files          5405     365     -5040     
  Lines        472672   29499   -443173     
  Branches      58189    5161    -53028     
============================================
- Hits          71257    1261    -69996     
+ Misses       393486   28095   -365391     
+ Partials       7929     143     -7786     
Flag Coverage Δ
uitests 4.27% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. May need some manual verifications

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9381 (QA-JID-402)

@DaanHoogland
Copy link
Contributor

works in FF and Chrome, but I don't think we need remove the copy console button here:
image

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. Tested changes in the Simulator UI and it's working as expected.

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rohityadavcloud
Copy link
Member Author

@DaanHoogland as the copy button isn't what most people want (they could just click the console button), I find that duplicated and annoying; so only keep the button in the actions button-bar. The info card is supposed for quick/common use-case so console button is still there.

@rohityadavcloud rohityadavcloud merged commit 50586a9 into apache:4.19 Jul 15, 2024
21 of 25 checks passed
@rohityadavcloud rohityadavcloud deleted the ui-assorted-fixes branch July 15, 2024 04:14
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024
* config.json: make configuration names consistent with other

Makes login related config param to be consistent with the original
`loginFooter`. Group them together.

Signed-off-by: Rohit Yadav <[email protected]>

* ui: assorted UI fixes and copy console URL fix

This brings in related buttons across some infra views and new columns
which are missing. Also fixes the copy console URL issue on some
browsers.

Signed-off-by: Rohit Yadav <[email protected]>

---------

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants