-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI assorted fixes #9381
UI assorted fixes #9381
Conversation
Makes login related config param to be consistent with the original `loginFooter`. Group them together. Signed-off-by: Rohit Yadav <[email protected]>
This brings in related buttons across some infra views and new columns which are missing. Also fixes the copy console URL issue on some browsers. Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
looks generally good, will test in FF and Chrome. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9381 +/- ##
============================================
- Coverage 15.07% 4.27% -10.81%
============================================
Files 5405 365 -5040
Lines 472672 29499 -443173
Branches 58189 5161 -53028
============================================
- Hits 71257 1261 -69996
+ Misses 393486 28095 -365391
+ Partials 7929 143 -7786
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm. May need some manual verifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm. Tested changes in the Simulator UI and it's working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
@DaanHoogland as the copy button isn't what most people want (they could just click the console button), I find that duplicated and annoying; so only keep the button in the actions button-bar. The info card is supposed for quick/common use-case so console button is still there. |
* config.json: make configuration names consistent with other Makes login related config param to be consistent with the original `loginFooter`. Group them together. Signed-off-by: Rohit Yadav <[email protected]> * ui: assorted UI fixes and copy console URL fix This brings in related buttons across some infra views and new columns which are missing. Also fixes the copy console URL issue on some browsers. Signed-off-by: Rohit Yadav <[email protected]> --------- Signed-off-by: Rohit Yadav <[email protected]>
UI fixes to address missing useful columns and fixes copy console button.
Remove unnecessary copy button on info card that looks congested and confusing.
Fixes #9368
Types of changes