UI: Fix backup offering buttons for instances in data view

[vishesh92]

Description

This PR fixes backup offering buttons for instances in data view

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Image before the changes for a instance with a backup offering

Image after the changes for a instance with a backup offering

How Has This Been Tested?

Assign a backup offering to an instance and check the buttons in the data view.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.07%. Comparing base (7db83db) to head (80b85fe).

Additional details and impacted files

@@             Coverage Diff             @@
##               4.19    #9391     +/-   ##
===========================================
  Coverage     15.07%   15.07%             
- Complexity    11170    11171      +1     
===========================================
  Files          5405     5405             
  Lines        472672   472672             
  Branches      60446    58552   -1894     
===========================================
+ Hits          71271    71272      +1     
  Misses       393472   393472             
+ Partials       7929     7928      -1     

Flag	Coverage Δ
uitests	4.27% <ø> (ø)
unittests	15.79% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vishesh92]

@blueorangutan ui

[blueorangutan]

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[sureshanaparti]

clgtm

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9391 (QA-JID-403)

[sureshanaparti]

Verified fix in qa simulator env.

[DaanHoogland]

code looks good in qa but removing the offering doesn't work:

I am not sure if the icon should be added if the removal of the offering is not allowed.

[DaanHoogland]

some issue found but the change works as expected