Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve tests for array expressions #1339

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jan 25, 2025

Which issue does this PR close?

Part of #1345

Rationale for this change

Continuing to improve type checking and testing for array expressions.

What changes are included in this PR?

How are these changes tested?

}
}

test("array_remove - test all types (convert from Parquet)") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turned out not to be very useful, since we don't support arrays when using COMET_CONVERT_FROM_PARQUET_ENABLED

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39.09%. Comparing base (f09f8af) to head (e2dbe88).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/scala/org/apache/comet/serde/arrays.scala 26.92% 18 Missing and 1 partial ⚠️
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 73.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1339       +/-   ##
=============================================
- Coverage     56.12%   39.09%   -17.03%     
- Complexity      976     2065     +1089     
=============================================
  Files           119      260      +141     
  Lines         11743    60305    +48562     
  Branches       2251    12833    +10582     
=============================================
+ Hits           6591    23578    +16987     
- Misses         4012    32239    +28227     
- Partials       1140     4488     +3348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants