-
Notifications
You must be signed in to change notification settings - Fork 254
feat: Support ANSI mode SUM (Decimal types) #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Support ANSI mode SUM (Decimal types) #2826
Conversation
|
@andygrove , Please kickoff CI whenever get a chance . This PR should essentially finish impl ANSI (along with #2600 ) for all numeric types |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
============================================
+ Coverage 56.12% 58.72% +2.60%
- Complexity 976 1463 +487
============================================
Files 119 167 +48
Lines 11743 15175 +3432
Branches 2251 2498 +247
============================================
+ Hits 6591 8912 +2321
- Misses 4012 4958 +946
- Partials 1140 1305 +165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fixed test failures by converting state variables into option and is_empty as per spark semantics . @andygrove , Please kickoff CI whenever you get a chance. |
|
Fixed scala 2.13 formatting failures |
Which issue does this PR close?
Closed #531 (Adds ANSI support for decimal inputs)
Rationale for this change
is_null,is_emptyflags). The only update here is to consolidate the state variables to 2 (optional i128 and an is_null flag). Unlike int sum, spark leverages both the sum and is_empty state vars in all modesWhat changes are included in this PR?
SumDecimalHow are these changes tested?