Skip to content

feat: Support ANSI mode SUM (Decimal types) #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+397 −171
Open

feat: Support ANSI mode SUM (Decimal types) #2826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5227115
support_ansi_sum_decimal_input
coderfender Nov 25, 2025
dbe1e4c
support_ansi_sum_decimal_input
coderfender Nov 25, 2025
28c260e
support_ansi_sum_decimal_input
coderfender Nov 26, 2025
5df4821
support_ansi_sum_decimal_input
coderfender Nov 28, 2025
272b661
support_ansi_sum_decimal_input
coderfender Nov 28, 2025
ac6b493
support_ansi_sum_decimal_input_fix_scala
coderfender Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion native/core/src/execution/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,7 +1870,9 @@ impl PhysicalPlanner {

let builder = match datatype {
DataType::Decimal128(_, _) => {
let func = AggregateUDF::new_from_impl(SumDecimal::try_new(datatype)?);
let eval_mode = from_protobuf_eval_mode(expr.eval_mode)?;
let func =
AggregateUDF::new_from_impl(SumDecimal::try_new(datatype, eval_mode)?);
AggregateExprBuilder::new(Arc::new(func), vec![child])
}
_ => {
Expand Down
2 changes: 1 addition & 1 deletion native/proto/src/proto/expr.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ message Count {
message Sum {
Expr child = 1;
DataType datatype = 2;
bool fail_on_error = 3;
EvalMode eval_mode = 3;
}

message Min {
Expand Down
4 changes: 2 additions & 2 deletions native/spark-expr/benches/aggregate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ use datafusion::physical_expr::expressions::Column;
use datafusion::physical_expr::PhysicalExpr;
use datafusion::physical_plan::aggregates::{AggregateExec, AggregateMode, PhysicalGroupBy};
use datafusion::physical_plan::ExecutionPlan;
use datafusion_comet_spark_expr::AvgDecimal;
use datafusion_comet_spark_expr::SumDecimal;
use datafusion_comet_spark_expr::{AvgDecimal, EvalMode};
use futures::StreamExt;
use std::hint::black_box;
use std::sync::Arc;
Expand Down Expand Up @@ -97,7 +97,7 @@ fn criterion_benchmark(c: &mut Criterion) {

group.bench_function("sum_decimal_comet", |b| {
let comet_sum_decimal = Arc::new(AggregateUDF::new_from_impl(
SumDecimal::try_new(DataType::Decimal128(38, 10)).unwrap(),
SumDecimal::try_new(DataType::Decimal128(38, 10), EvalMode::Legacy).unwrap(),
));
b.to_async(&rt).iter(|| {
black_box(agg_test(
Expand Down
Loading
Loading