refactor: make SqlToRel::new derive the parser options from the context provider #14822
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Previously, the
SqlToRel::new
method uses a defaultParserOptions
.Now, its parser options derive the
SqlParserOptions
from the context provider.Are these changes tested?
Yes, covered by existing test cases.
Are there any user-facing changes?
Previously, users need to set the parser options once when creating a session config, and again when creating a
SqlToRel
.Now, users can set the parser options only once when creating a session config, and expect each
SqlToRel
's created bySqlToRel::new
derives the parser options in the session config.