Skip to content

Conversation

snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Aug 18, 2025

What is the purpose of the change

The PR to support SHOW CREATE MATERIALIZED TABLE,
looks like this is a missed thing from FLINK-35187

Brief change log

parser, ShowCreateUtil ,tests

Verifying this change

Mostly ShowCreateUtilTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes )
  • If yes, how is the feature documented? ( not documented (seems the generic issue for Materialized table which should be addressed under FLINK-35688))

@snuyanzin snuyanzin changed the title [FLINK-37827][table] Add support for SHOW CREATE MATERIZLIED TABLE [FLINK-37827][table] Add support for SHOW CREATE MATERIAZLIED TABLE Aug 18, 2025
@snuyanzin snuyanzin changed the title [FLINK-37827][table] Add support for SHOW CREATE MATERIAZLIED TABLE [FLINK-37827][table] Add support for SHOW CREATE MATERIALIZED TABLE Aug 18, 2025
@flinkbot
Copy link
Collaborator

flinkbot commented Aug 18, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Aug 19, 2025
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Aug 26, 2025
@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin snuyanzin requested a review from davidradl August 27, 2025 11:29
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Aug 28, 2025
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for leaving the code base in a better shape. I had just one last comment and potentially a followup task.

static String extractFreshness(ResolvedCatalogMaterializedTable materializedTable) {
final IntervalFreshness definitionFreshness = materializedTable.getDefinitionFreshness();
return String.format(
"FRESHNESS = INTERVAL '%s' %s",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the SQL parser allow parsing INTERVAL '5' DAY. Doesn't it need to be plural. Also why is the interval a string, this looks like a bug to me. Maybe we should change it before it is too late.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it seems the SQL parser allows parsing INTERVAL '5' DAY

@snuyanzin snuyanzin merged commit 6f2be0a into apache:master Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-reviewed PR has been reviewed by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants