-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-37827][table] Add support for SHOW CREATE MATERIALIZED TABLE
#26923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SHOW CREATE MATERIZLIED TABLE
SHOW CREATE MATERIAZLIED TABLE
SHOW CREATE MATERIAZLIED TABLE
SHOW CREATE MATERIALIZED TABLE
...ink-table-api-java/src/test/java/org/apache/flink/table/api/internal/ShowCreateUtilTest.java
Outdated
Show resolved
Hide resolved
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for leaving the code base in a better shape. I had just one last comment and potentially a followup task.
static String extractFreshness(ResolvedCatalogMaterializedTable materializedTable) { | ||
final IntervalFreshness definitionFreshness = materializedTable.getDefinitionFreshness(); | ||
return String.format( | ||
"FRESHNESS = INTERVAL '%s' %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the SQL parser allow parsing INTERVAL '5' DAY
. Doesn't it need to be plural. Also why is the interval a string, this looks like a bug to me. Maybe we should change it before it is too late.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it seems the SQL parser allows parsing INTERVAL '5' DAY
What is the purpose of the change
The PR to support
SHOW CREATE MATERIALIZED TABLE
,looks like this is a missed thing from FLINK-35187
Brief change log
parser,
ShowCreateUtil
,testsVerifying this change
Mostly
ShowCreateUtilTest
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: ( no)Documentation