-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-37827][table] Add support for SHOW CREATE MATERIALIZED TABLE
#26923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
...-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowCreateMaterializedTable.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.flink.sql.parser.dql; | ||
|
||
import org.apache.calcite.sql.SqlIdentifier; | ||
import org.apache.calcite.sql.SqlKind; | ||
import org.apache.calcite.sql.SqlNode; | ||
import org.apache.calcite.sql.SqlOperator; | ||
import org.apache.calcite.sql.SqlSpecialOperator; | ||
import org.apache.calcite.sql.SqlWriter; | ||
import org.apache.calcite.sql.parser.SqlParserPos; | ||
|
||
import java.util.Collections; | ||
import java.util.List; | ||
|
||
/** SHOW CREATE MATERIALIZED TABLE sql call. */ | ||
public class SqlShowCreateMaterializedTable extends SqlShowCreate { | ||
public static final SqlSpecialOperator OPERATOR = | ||
new SqlSpecialOperator("SHOW CREATE MATERIALIZED TABLE", SqlKind.OTHER_DDL); | ||
|
||
public SqlShowCreateMaterializedTable(SqlParserPos pos, SqlIdentifier sqlIdentifier) { | ||
super(pos, sqlIdentifier); | ||
} | ||
|
||
public SqlIdentifier getMaterializedTableName() { | ||
return sqlIdentifier; | ||
} | ||
|
||
public String[] getFullMaterializedTableName() { | ||
return sqlIdentifier.names.toArray(new String[0]); | ||
} | ||
|
||
@Override | ||
public SqlOperator getOperator() { | ||
return OPERATOR; | ||
} | ||
|
||
@Override | ||
public List<SqlNode> getOperandList() { | ||
return Collections.singletonList(sqlIdentifier); | ||
} | ||
|
||
@Override | ||
public void unparse(SqlWriter writer, int leftPrec, int rightPrec) { | ||
writer.keyword(OPERATOR.getName()); | ||
sqlIdentifier.unparse(writer, leftPrec, rightPrec); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
...src/main/java/org/apache/flink/table/operations/ShowCreateMaterializedTableOperation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.flink.table.operations; | ||
|
||
import org.apache.flink.annotation.Internal; | ||
import org.apache.flink.table.api.ValidationException; | ||
import org.apache.flink.table.api.internal.ShowCreateUtil; | ||
import org.apache.flink.table.api.internal.TableResultInternal; | ||
import org.apache.flink.table.catalog.ContextResolvedTable; | ||
import org.apache.flink.table.catalog.ObjectIdentifier; | ||
|
||
import static org.apache.flink.table.api.internal.TableResultUtils.buildStringArrayResult; | ||
|
||
/** Operation to describe a SHOW CREATE MATERIALIZED TABLE statement. */ | ||
@Internal | ||
public class ShowCreateMaterializedTableOperation implements ShowOperation { | ||
private final ObjectIdentifier tableIdentifier; | ||
|
||
public ShowCreateMaterializedTableOperation(ObjectIdentifier sqlIdentifier) { | ||
this.tableIdentifier = sqlIdentifier; | ||
} | ||
|
||
@Override | ||
public String asSummaryString() { | ||
return String.format( | ||
"SHOW CREATE MATERIALIZED TABLE %s", tableIdentifier.asSummaryString()); | ||
} | ||
|
||
@Override | ||
public TableResultInternal execute(Context ctx) { | ||
ContextResolvedTable table = | ||
ctx.getCatalogManager() | ||
.getTable(tableIdentifier) | ||
.orElseThrow( | ||
() -> | ||
new ValidationException( | ||
String.format( | ||
"Could not execute SHOW CREATE MATERIALIZED TABLE. Materialized table with identifier %s does not exist.", | ||
tableIdentifier.asSerializableString()))); | ||
String resultRow = | ||
ShowCreateUtil.buildShowCreateMaterializedTableRow( | ||
table.getResolvedTable(), tableIdentifier, table.isTemporary()); | ||
|
||
return buildStringArrayResult("result", new String[] {resultRow}); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the SQL parser allow parsing
INTERVAL '5' DAY
. Doesn't it need to be plural. Also why is the interval a string, this looks like a bug to me. Maybe we should change it before it is too late.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it seems the SQL parser allows parsing INTERVAL '5' DAY