Skip to content

[GLUTEN-10773][VL] Add support for Velox expression.max_compiled_regexes configuration#10776

Merged
philo-he merged 3 commits intoapache:mainfrom
NEUpanning:max-compiled-regex
Oct 9, 2025
Merged

[GLUTEN-10773][VL] Add support for Velox expression.max_compiled_regexes configuration#10776
philo-he merged 3 commits intoapache:mainfrom
NEUpanning:max-compiled-regex

Conversation

@NEUpanning
Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

Fixes #10773

How was this patch tested?

Integrated test

@github-actions github-actions bot added the VELOX label Sep 22, 2025
@github-actions
Copy link
Copy Markdown

#10773

@github-actions github-actions bot added the DOCS label Sep 23, 2025
@NEUpanning
Copy link
Copy Markdown
Contributor Author

@marin-ma Could you help to take a look? Thanks.

@NEUpanning
Copy link
Copy Markdown
Contributor Author

@philo-he Would you like to take a look? Thanks!

Comment thread docs/Configuration.md
| spark.gluten.sql.columnar.shuffle.celeborn.fallback.enabled | true | If enabled, fall back to ColumnarShuffleManager when celeborn service is unavailable.Otherwise, throw an exception. |
| spark.gluten.sql.columnar.shuffle.celeborn.useRssSort | true | If true, use RSS sort implementation for Celeborn sort-based shuffle.If false, use Gluten's row-based sort implementation. Only valid when `spark.celeborn.client.spark.shuffle.writer` is set to `sort`. |
| spark.gluten.sql.columnar.shuffle.codec | <undefined> | By default, the supported codecs are lz4 and zstd. When spark.gluten.sql.columnar.shuffle.codecBackend=qat,the supported codecs are gzip and zstd. |
| spark.gluten.sql.columnar.partial.generate | true | Evaluates the non-offload-able HiveUDTF using vanilla Spark generator |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems no need change, can we remove it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was generated by dev/gen_all_config_docs.sh. Next one who wants to generate doc will submit same change.

Copy link
Copy Markdown
Member

@philo-he philo-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Thanks.

Comment thread backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala Outdated
Comment thread backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala Outdated
@NEUpanning NEUpanning requested a review from philo-he September 30, 2025 02:46
Copy link
Copy Markdown
Member

@philo-he philo-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. cc @jackylee-ch

@NEUpanning
Copy link
Copy Markdown
Contributor Author

@philo-he Could you merge this PR? Thanks.

@philo-he philo-he changed the title [GLUTEN-10773][VL] Support expression.max_compiled_regexes configuration [GLUTEN-10773][VL] Add support for Velox expression.max_compiled_regexes configuration Oct 9, 2025
@philo-he philo-he merged commit d9263b2 into apache:main Oct 9, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VL] Support expression.max_compiled_regexes configuration

3 participants