Skip to content

[GLUTEN-10773][VL] Add support for Velox expression.max_compiled_regexes configuration #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philo-he merged 3 commits into from
Oct 9, 2025
Merged

[GLUTEN-10773][VL] Add support for Velox expression.max_compiled_regexes configuration #10776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf309b7
initial
NEUpanning Sep 22, 2025
6ae5de3
add doc
NEUpanning Sep 23, 2025
447705c
review change
NEUpanning Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,4 +646,12 @@ object VeloxConfig {
.internal()
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("10MB")

val VELOX_MAX_COMPILED_REGEXES =
buildConf("spark.gluten.sql.columnar.backend.velox.maxCompiledRegexes")
.doc(
"Controls maximum number of compiled regular expression patterns per function " +
"instance per thread of execution.")
.intConf
.createWithDefault(100)
}
3 changes: 3 additions & 0 deletions cpp/velox/compute/WholeStageResultIterator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@ std::unordered_map<std::string, std::string> WholeStageResultIterator::getQueryC
configs[velox::core::QueryConfig::kSparkJsonIgnoreNullFields] =
std::to_string(veloxCfg_->get<bool>(kSparkJsonIgnoreNullFields, true));

configs[velox::core::QueryConfig::kExprMaxCompiledRegexes] =
std::to_string(veloxCfg_->get<int32_t>(kExprMaxCompiledRegexes, 100));

#ifdef GLUTEN_ENABLE_GPU
configs[cudf_velox::kCudfEnabled] = std::to_string(veloxCfg_->get<bool>(kCudfEnabled, false));
#endif
Expand Down
2 changes: 2 additions & 0 deletions cpp/velox/config/VeloxConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ const uint64_t kVeloxMemReclaimMaxWaitMsDefault = 3600000; // 60min
const std::string kHiveConnectorId = "test-hive";
const std::string kVeloxCacheEnabled = "spark.gluten.sql.columnar.backend.velox.cacheEnabled";

const std::string kExprMaxCompiledRegexes = "spark.gluten.sql.columnar.backend.velox.maxCompiledRegexes";

// memory cache
const std::string kVeloxMemCacheSize = "spark.gluten.sql.columnar.backend.velox.memCacheSize";
const uint64_t kVeloxMemCacheSizeDefault = 1073741824; // 1G
Expand Down
Loading