Skip to content

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Oct 7, 2025

No description provided.

@PDavid PDavid self-assigned this Oct 7, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid PDavid marked this pull request as ready for review October 7, 2025 15:10
@PDavid PDavid requested a review from stoty October 7, 2025 15:10
@PDavid
Copy link
Contributor Author

PDavid commented Oct 7, 2025

Tested this with the following commands:

mvn clean install -DskipTests && mvn site
mvn test -Dtest=TestSnapshotProcedureEarlyExpiration -pl hbase-server && mvn surefire-report:report-only

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@PDavid
Copy link
Contributor Author

PDavid commented Oct 9, 2025

Opened a backport for branch-3 here: #7367

This checkstyle version is not working with Java 8 so this cannot be backported to branch-x branches.

@PDavid PDavid force-pushed the HBASE-29609-checkstyle-upgrade-2 branch from 8bb4be2 to 54fb613 Compare October 16, 2025 08:04
@PDavid
Copy link
Contributor Author

PDavid commented Oct 16, 2025

Rebased the branch to make sure it works fine with latest master.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 48s master passed
+1 💚 compile 12m 11s master passed
+1 💚 spotless 1m 16s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 53s the patch passed
+1 💚 compile 13m 29s the patch passed
+1 💚 javac 13m 29s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 17m 41s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 1m 8s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
67m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7365
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname Linux 6f3e7ff467b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 54fb613
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 190 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 37s master passed
+1 💚 compile 2m 9s master passed
+1 💚 javadoc 2m 1s master passed
+1 💚 shadedjars 6m 21s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 2s the patch passed
+1 💚 compile 2m 12s the patch passed
+1 💚 javac 2m 12s the patch passed
+1 💚 javadoc 1m 58s the patch passed
+1 💚 shadedjars 6m 13s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 285m 7s root in the patch passed.
320m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7365
Optional Tests javac javadoc unit shadedjars compile
uname Linux e035cd466f1e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 54fb613
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/testReport/
Max. process+thread count 8131 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid PDavid merged commit 6d7829a into apache:master Oct 16, 2025
1 check passed
@PDavid PDavid deleted the HBASE-29609-checkstyle-upgrade-2 branch October 16, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants