Skip to content

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Oct 8, 2025

No description provided.

@PDavid PDavid self-assigned this Oct 8, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
Copy link
Contributor Author

PDavid commented Oct 9, 2025

TestSCPWithMetaWithoutZKCoordinated test timed out in the PR build. I think it is unrelated to this change.

@PDavid PDavid marked this pull request as ready for review October 9, 2025 06:30
@PDavid PDavid requested a review from stoty October 9, 2025 06:30
@PDavid PDavid added the backport This PR is a back port of some issue or issues already committed to master label Oct 9, 2025
@PDavid
Copy link
Contributor Author

PDavid commented Oct 9, 2025

This is a backport of #7365 to branch-3.

Tested this with the following commands:

mvn clean install -DskipTests && mvn site
mvn test -Dtest=TestSnapshotProcedureEarlyExpiration -pl hbase-server && mvn surefire-report:report-only

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid PDavid force-pushed the HBASE-29609-checkstyle-upgrade-branch-3 branch from 6d464e2 to 4196f8c Compare October 17, 2025 11:49
@PDavid
Copy link
Contributor Author

PDavid commented Oct 17, 2025

Rebased the feature branch to have latest changes of branch-3.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid PDavid force-pushed the HBASE-29609-checkstyle-upgrade-branch-3 branch from 4196f8c to b178e09 Compare November 5, 2025 09:46
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-3 Compile Tests _
+1 💚 mvninstall 3m 40s branch-3 passed
+1 💚 compile 8m 47s branch-3 passed
+1 💚 spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 14s the patch passed
+1 💚 compile 8m 41s the patch passed
+1 💚 javac 8m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 12m 25s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 47s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
46m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7367
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname Linux 0d9db57b4e15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-3 / b178e09
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 189 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚 mvninstall 3m 44s branch-3 passed
+1 💚 compile 2m 13s branch-3 passed
+1 💚 javadoc 1m 59s branch-3 passed
+1 💚 shadedjars 6m 16s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 9s the patch passed
+1 💚 compile 2m 11s the patch passed
+1 💚 javac 2m 11s the patch passed
+1 💚 javadoc 1m 56s the patch passed
+1 💚 shadedjars 6m 9s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 284m 18s /patch-unit-root.txt root in the patch failed.
320m 20s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7367
Optional Tests javac javadoc unit shadedjars compile
uname Linux 947a63dc3fdf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-3 / b178e09
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/testReport/
Max. process+thread count 7910 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Nov 11, 2025

This is the same as the master patch @PDavid ?

@PDavid
Copy link
Contributor Author

PDavid commented Nov 11, 2025

This is the same as the master patch @PDavid ?

@stoty Thanks, yes, this patch is the same as on master (#7365).

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants