feat: add visit type support #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lidavidm
reviewed
May 10, 2025
lidavidm
approved these changes
May 10, 2025
wgtmac
approved these changes
May 12, 2025
| * under the License. | ||
| */ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
nit: add the \file docstring and mention that it is adapted from Apache Arrow.
There was a problem hiding this comment.
Will add later today, thanks for the suggestion.
There was a problem hiding this comment.
If we take big pieces from other projects, then we also want to add that to the LICENSE:
For example in PyIceberg: https://github.com/apache/iceberg-python/blob/260ef54e3920d435ae3b2ccda090e66f9c1ac015/LICENSE#L206-L213
There was a problem hiding this comment.
Sounds good, let's include that in both the LICENSE and NOTICE.
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
The visit type infrastructure is adapted from apache arrow. Add a reference note per @lidavidm's suggestion. Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
TypeIdfield to each concrete type to enable macro-based type visitor support.