MINOR: Fix the CLIENT_QUOTA_CALLBACK_CLASS_CONFIG document #18713
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Jan 27, 2025
| @@ -55,6 +55,7 @@ public class QuotaConfig { | |||
| public static final String CLIENT_QUOTA_CALLBACK_CLASS_CONFIG = "client.quota.callback.class"; | |||
| public static final String CLIENT_QUOTA_CALLBACK_CLASS_DOC = "The fully qualified name of a class that implements the ClientQuotaCallback interface, " + | |||
| "which is used to determine quota limits applied to client requests. " + | |||
| "By default, the <user> and <client-id> quotas that are stored. " + | |||
There was a problem hiding this comment.
It seems to me the key is "applied" rather than "stored". Callback users are primarily concerned with understanding the specific quotas they can utilize through this interface.
@ijuma FYI
There was a problem hiding this comment.
It make sense to me, I think I can change to "that are stored and applied".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion: https://github.com/apache/kafka/pull/18346/files/7fa0dfd72d516474f783653369622a2c906cd07e#r1929621640
Committer Checklist (excluded from commit message)