Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix the CLIENT_QUOTA_CALLBACK_CLASS_CONFIG document #18713

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

MINOR: Fix the CLIENT_QUOTA_CALLBACK_CLASS_CONFIG document #18713

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c9f02a
update the document
m1a2st Jan 27, 2025
9cb5d40
addressed by comments
m1a2st Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ public class QuotaConfig {
public static final String CLIENT_QUOTA_CALLBACK_CLASS_CONFIG = "client.quota.callback.class";
public static final String CLIENT_QUOTA_CALLBACK_CLASS_DOC = "The fully qualified name of a class that implements the ClientQuotaCallback interface, " +
"which is used to determine quota limits applied to client requests. " +
"By default, the <user> and <client-id&gt quotas that are stored. " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me the key is "applied" rather than "stored". Callback users are primarily concerned with understanding the specific quotas they can utilize through this interface.

@ijuma FYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It make sense to me, I think I can change to "that are stored and applied".

"For any given request, the most specific quota that matches the user principal of the session and the client-id of the request is applied.";

public static final String LEADER_REPLICATION_THROTTLED_REPLICAS_CONFIG = "leader.replication.throttled.replicas";
Expand Down
Loading