MINOR: improve error message on TLS certificate validation failure #20747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A TLS handshake failure results in an `INFO` log with a generic message of `SSL handshake failed`. The absence of a stacktrace, which I believe is to avoid polluting the logs in case of a misbehaving client, makes it hard to diagnose the underlying cause of the handshake failure. This change modifies the message to include the certificate failure reason which can provide a valuable hint to users regarding the underlying issue during an incident.
gaurav-narula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TLS handshake failure results in an
INFOlog with a generic message ofSSL handshake failed. The absence of a stacktrace, which I believe is to avoid polluting the logs in case of a misbehaving client, makes it hard to diagnose the underlying cause of the handshake failure.This change modifies the message to include the certificate failure reason which can provide a valuable hint to users regarding the underlying issue during an incident.