Skip to content

MINOR: improve error message on TLS certificate validation failure #20747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+13 −0
Open

MINOR: improve error message on TLS certificate validation failure #20747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions clients/src/main/java/org/apache/kafka/common/network/Selector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import java.nio.channels.SelectionKey;
import java.nio.channels.SocketChannel;
import java.nio.channels.UnresolvedAddressException;
import java.security.cert.CertPathValidatorException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
Expand Down Expand Up @@ -619,6 +620,10 @@ void pollSelectionKeys(Set<SelectionKey> selectionKeys,
String exceptionMessage = e.getMessage();
if (e instanceof DelayedResponseAuthenticationException)
exceptionMessage = e.getCause().getMessage();
CertPathValidatorException certPathValidatorException = maybeGetCertPathValidatorException(e);
if (certPathValidatorException != null) {
exceptionMessage += "; certificate validation failed with reason " + certPathValidatorException.getReason();
}
log.info("Failed {}authentication with {} ({})", isReauthentication ? "re-" : "",
desc, exceptionMessage);
} else {
Expand All @@ -635,6 +640,14 @@ void pollSelectionKeys(Set<SelectionKey> selectionKeys,
}
}

private CertPathValidatorException maybeGetCertPathValidatorException(Throwable throwable) {
Throwable current = throwable;
while (current != null && !(current instanceof CertPathValidatorException)) {
current = current.getCause();
}
return (CertPathValidatorException) current;
}

private void attemptWrite(SelectionKey key, KafkaChannel channel, long nowNanos) throws IOException {
if (channel.hasSend()
&& channel.ready()
Expand Down