KAFKA-19807: Add RPC-level integration tests for StreamsGroupHeartbeat [2/2] #20762
+594
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive integration tests for the StreamsGroupHeartbeat RPC, validating group coordinator behavior across various scenarios including internal topic creation, dynamic configuration changes, member expiration/rejoining, and coordinator restarts.
Key changes:
- Added four new integration tests for different StreamsGroupHeartbeat scenarios
- Implemented helper methods for topology creation and task ID conversion
- Configured test-specific cluster properties for heartbeat and session timeouts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| streamsGroupHeartbeatResponse1 = connectAndReceive[StreamsGroupHeartbeatResponse](streamsGroupHeartbeatRequest1) | ||
| streamsGroupHeartbeatResponse1.data.errorCode == Errors.NONE.code() && | ||
| streamsGroupHeartbeatResponse1.data.standbyTasks()!= null |
There was a problem hiding this comment.
Missing space before != operator. Should be != null instead of != null.
Suggested change
| streamsGroupHeartbeatResponse1.data.standbyTasks()!= null | |
| streamsGroupHeartbeatResponse1.data.standbyTasks() != null |
lucasbru
reviewed
Oct 24, 2025
|
@lucliu1108 You need to add the right header to the file (meant to comment in this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket: https://issues.apache.org/jira/browse/KAFKA-19807
Follow up on #20757, add tests that:
(
streams.num.standby.replicas) changeReviewers: @lucasbru