Skip to content

KAFKA-19807: Add RPC-level integration tests for StreamsGroupHeartbeat [2/2] #20762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from
+568 −0
Open

KAFKA-19807: Add RPC-level integration tests for StreamsGroupHeartbeat [2/2] #20762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cf02ed4
add other tests
lucliu1108 Oct 23, 2025
cc7a50d
add newCoordinator test
lucliu1108 Oct 24, 2025
90a9678
add more asserts
lucliu1108 Oct 24, 2025
85296b6
remove redundant code
lucliu1108 Oct 24, 2025
77a1181
adjust comments
lucliu1108 Oct 24, 2025
d2d7d3b
add file header
lucliu1108 Oct 24, 2025
b581d6d
Update core/src/test/scala/unit/kafka/server/StreamsGroupHeartbeatReq…
lucliu1108 Oct 25, 2025
9a2512d
address comments
lucliu1108 Oct 26, 2025
149f8ff
resolve conflicts
lucliu1108 Oct 26, 2025
c6fbf11
remove unnecessary param
lucliu1108 Oct 26, 2025
5e48471
fix typo
lucliu1108 Oct 26, 2025
7165fb3
fix redundant null check
lucliu1108 Oct 26, 2025
428ca7d
revise java list import
lucliu1108 Oct 26, 2025
26139b2
revise variable name
lucliu1108 Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,9 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) {
warmupTasks: List[StreamsGroupHeartbeatRequestData.TaskIds] = null,
topology: StreamsGroupHeartbeatRequestData.Topology = null,
expectedError: Errors = Errors.NONE,
processId: String = null,
version: Short = ApiKeys.STREAMS_GROUP_HEARTBEAT.latestVersion(isUnstableApiEnabled)

): StreamsGroupHeartbeatResponseData = {
val streamsGroupHeartbeatRequest = new StreamsGroupHeartbeatRequest.Builder(
new StreamsGroupHeartbeatRequestData()
Expand All @@ -892,6 +894,7 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) {
.setStandbyTasks(standbyTasks.asJava)
.setWarmupTasks(warmupTasks.asJava)
.setTopology(topology)
.setProcessId(processId)
).build(version)

// Send the request until receiving a successful response. There is a delay
Expand Down
Loading