[SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro… #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm not sure if this fix is the best approach, and if there is need for a test, but this fix at least solved the problem in my reproducer, allowing me to see the stack trace of the fork error. |
Comment on lines
+656
to
+661
| else if ( forkClient.isErrorInFork() ) | ||
| { | ||
| final StackTraceWriter stackTrace = forkClient.getErrorInFork(); | ||
| booterForkException = | ||
| new SurefireBooterForkException( stackTrace.writeTraceToString() ); | ||
| } |
Member
There was a problem hiding this comment.
Please look line 711 - 733
StackTrace is printed if Maven command is started with -e option
Contributor
There was a problem hiding this comment.
@fl4via
Pls have a look at the comments and answers. How can we continue with this?
|
Resolve #2904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rInFork
Jira: https://issues.apache.org/jira/browse/SUREFIRE-1946