Skip to content

[SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro… #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro… #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...efire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,12 @@ private RunResult fork( Object testSet, PropertiesWrapper providerProperties, Fo
{
runResult = timeout( reporter.getGlobalRunStatistics().getRunResult() );
}
else if ( forkClient.isErrorInFork() )
{
final StackTraceWriter stackTrace = forkClient.getErrorInFork();
booterForkException =
new SurefireBooterForkException( stackTrace.writeTraceToString() );
}
Comment on lines +656 to +661
Copy link
Member

@slawekjaranowski slawekjaranowski Dec 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look line 711 - 733
StackTrace is printed if Maven command is started with -e option

Copy link
Contributor

@Tibor17 Tibor17 Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fl4via
Pls have a look at the comments and answers. How can we continue with this?

else if ( result != SUCCESS )
{
booterForkException =
Expand Down