system/uorb: require that LIBC_FLOATINGPOINT be enabled for DEBUG_UORB #2987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request closes the issue raised here.
Now
DEBUG_UORB
depends onLIBC_FLOATINGPOINT
. This is because it is not possible to view sensor debug output without this enabled, which is only a problem for systems without an FPU (systems with an FPU have this enabled by default).Impact
Users now have to enable
LIBC_FLOATINGPOINT
on systems without an FPU in order to useDEBUG_UORB
. The dependency marked withdepends on
means that the uORB debug option will not be visible untilLIBC_FLOATINGPOINT
is selected, but this was determined to be acceptable in the discussion under the linked issue.This prevents the annoyance of re-flashing the device because floating point printing was disabled, rendering debug output almost useless.
I have also included a compile time error for the configuration mismatch.
Testing
Verified that enabling
LIBC_FLOATINGPOINT
causedDEBUG_UORB
to appear and that the dependency was marked in Kconfig.Output after building by selecting
LIBC_FLOATINGPOINT
followed byDEBUG_UORB
in Kconfig.