-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/mcx-nxxx: Add support for NXP MCX-N236 CPU #15879
Conversation
9f4fb56
to
2fe59e2
Compare
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs significantly more detail and more thorough testing before it can be considered complete. It needs to convince reviewers that the changes are well-motivated, correctly implemented, and thoroughly tested. |
6deaf8f
to
b4f910c
Compare
This adds minimal support for NXP MCX-N236 CPU. Peripherals supported are: - GPIO - PINMUX - CLOCK - LPUART An example board, FRDM-MCXN236 is also added, with a basic profile that boots into nsh. Signed-off-by: Ville Juven <[email protected]>
b4f910c
to
591b627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have this hardware to run actual tests, but the patch merges cleanly, builds successfully, and code LGTM. Only one minor nit (spelling in a comment)... Thanks for adding new architecture and board support!
modifyreg32(priv->uartbase + NXXX_LPUART_BAUD_OFFSET, | ||
0, LPUART_BAUD_RDMAE); | ||
|
||
/* Enable interrupt on idle and erros */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* Enable interrupt on idle and erros */ | |
/* Enable interrupt on idle and errors */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pussuw amazing work!! :-)
Summary
This adds minimal support for NXP MCX-N236 CPU. Peripherals supported are:
An example board, FRDM-MCXN236 is also added, with a basic profile that boots into nsh.
Impact
No impact on existing code, a new architecture entirely is added with an example board implementation.
Testing
Tested by booting nsh on FRDM-MCX236 evaluation kit.
Ran ostest once.