[SPARK-51039][BUILD] Fix hive-llap-common dependency to use hive.llap.scope in root pom.xml
#49733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lap.scope` in root pom
dongjoon-hyun
force-pushed
the
SPARK-51039
branch
from
23115f7 to
924e6d3
Compare
dongjoon-hyun
changed the title
hive-llap-common dependency to use hive.llap.scope in root pomhive-llap-common dependency to use hive.llap.scope in root pom.xml
LuciferYang
approved these changes
Jan 30, 2025
|
Thank you, @LuciferYang ! |
|
The one failure is irrelevant and flaky one. Merged to master/4.0/3.5. |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 30, 2025
…lap.scope` in root `pom.xml` ### What changes were proposed in this pull request? This PR aims to fix `hive-llap-common` dependency to use `hive.llap.scope` in root pom for Apache Spark 3.5 and 4.0. ### Why are the changes needed? Apache Spark has been supposed to use `hive.llap.scope` for `hive-llap-common` dependency and `hive` module do it correctly. https://github.com/apache/spark/blob/a1b0f256c04e5b632075358d1e2f946e64588da6/sql/hive/pom.xml#L119-L123 Since Apache Spark 3.0.0 (SPARK-27176), the root `pom.xml` file has been using a wrong scope mistakenly. Probably, it's due to `-Phive-provided` support. This causes a confusion to other external systems and the users. We had better fix the root `pom.xml` to use `hive.llap.scope` correctly. - #23788 ### Does this PR introduce _any_ user-facing change? No, there is no change technically because `hive` module has been using a correct scope. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49733 from dongjoon-hyun/SPARK-51039. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7243de6) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 30, 2025
…lap.scope` in root `pom.xml` This PR aims to fix `hive-llap-common` dependency to use `hive.llap.scope` in root pom for Apache Spark 3.5 and 4.0. Apache Spark has been supposed to use `hive.llap.scope` for `hive-llap-common` dependency and `hive` module do it correctly. https://github.com/apache/spark/blob/a1b0f256c04e5b632075358d1e2f946e64588da6/sql/hive/pom.xml#L119-L123 Since Apache Spark 3.0.0 (SPARK-27176), the root `pom.xml` file has been using a wrong scope mistakenly. Probably, it's due to `-Phive-provided` support. This causes a confusion to other external systems and the users. We had better fix the root `pom.xml` to use `hive.llap.scope` correctly. - #23788 No, there is no change technically because `hive` module has been using a correct scope. Pass the CIs. No. Closes #49733 from dongjoon-hyun/SPARK-51039. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7243de6) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
hive-llap-commondependency to usehive.llap.scopein root pom for Apache Spark 3.5 and 4.0.Why are the changes needed?
Apache Spark has been supposed to use
hive.llap.scopeforhive-llap-commondependency andhivemodule do it correctly.spark/sql/hive/pom.xml
Lines 119 to 123 in a1b0f25
Since Apache Spark 3.0.0 (SPARK-27176), the root
pom.xmlfile has been using a wrong scope mistakenly. Probably, it's due to-Phive-providedsupport. This causes a confusion to other external systems and the users. We had better fix the rootpom.xmlto usehive.llap.scopecorrectly.Does this PR introduce any user-facing change?
No, there is no change technically because
hivemodule has been using a correct scope.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.