Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Data Generation & Plot Tests: #177

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

PiyushPanwarFST
Copy link
Contributor

@PiyushPanwarFST PiyushPanwarFST commented Mar 13, 2025

  • Added asserts in test_plot_bf().
  • Documented plot_energy() in plot.rst.
  • Added test cases for energyplot.py.
  • Updated generate_base_data():
    • Added prior group with variables.
    • Included "energy" variable in sample_stats.

📚 Documentation preview 📚: https://arviz-plots--177.org.readthedocs.build/en/177/

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (8be9a44) to head (bbd6f62).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   73.80%   74.41%   +0.61%     
==========================================
  Files          34       34              
  Lines        3897     3897              
==========================================
+ Hits         2876     2900      +24     
+ Misses       1021      997      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Added asserts in test_plot_bf().
* Documented plot_energy() in plot.rst.
* Added test cases for energyplot.py.
* Updated generate_base_data():
  - Added prior group with variables.
  - Included "energy" variable in sample_stats.

Signed-off-by: PiyushPanwarFST <[email protected]>
@PiyushPanwarFST
Copy link
Contributor Author

Thanks for the review!
Kept the third parameter as theta is 3D, removing it broke the implementation.
Let me know if it can be improved further.

Copy link
Contributor

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that was my mistake.

@aloctavodia aloctavodia merged commit 17aa329 into arviz-devs:main Mar 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants