Transition to salsa coarse-grained tracked structs #15763
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
commented
Jan 27, 2025
| @@ -18,7 +18,7 @@ use super::path::{ModulePath, SearchPath, SearchPathValidationError}; | |||
|
|
|||
| /// Resolves a module name to a module. | |||
| pub fn resolve_module(db: &dyn Db, module_name: &ModuleName) -> Option<Module> { | |||
| let interned_name = ModuleNameIngredient::new(db, module_name); | |||
| let interned_name = ModuleNameIngredient::new(db, module_name.clone()); | |||
There was a problem hiding this comment.
This change was caused by the new bounds introduced in salsa-rs/salsa@f428a94. I'm not sure why there's no blanket implementation for &T anymore.
ibraheemdev
force-pushed
the
salsa-coarse-deps
branch
from
6a70801 to
184a795
Compare
CodSpeed Performance ReportMerging #15763 will improve performances by 15.64%Comparing Summary
Benchmarks breakdown
|
ibraheemdev
force-pushed
the
salsa-coarse-deps
branch
from
184a795 to
e6badd1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transition to using coarse-grained tracked structs (depends on salsa-rs/salsa#657). For now, this PR doesn't add any
#[tracked]fields, meaning that any changes cause the entire struct to be invalidated. It also changesAstNodeRefto be compared/hashed by pointer address, instead of performing a deep AST comparison.Test Plan
This yields a 10-15% improvement on my machine (though weirdly some runs were 5-10% without being flagged as inconsistent by criterion, is there some non-determinism involved?). It's possible that some of this is unrelated, I'll try applying the patch to the current salsa version to make sure.