Skip to content

Update custom_ops.py #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update custom_ops.py #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions s2fft/precompute_transforms/custom_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def wigner_subset_to_s2(
return np.fft.ifft(x, axis=-2, norm="forward")


@partial(jit, static_argnums=(3, 4))
# @partial(jit, static_argnums=(3, 4))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @partial(jit, static_argnums=(3, 4))

We generally shouldn't comment out code as we can always recover snippets from git history - this is likely to be what is causing the linting failures.

def wigner_subset_to_s2_jax(
flmn: jnp.ndarray,
spins: jnp.ndarray,
Expand Down Expand Up @@ -209,7 +209,7 @@ def so3_to_wigner_subset(
return s2_to_wigner_subset(x, spins, DW, L, sampling)


@partial(jit, static_argnums=(3, 4, 5))
# @partial(jit, static_argnums=(3, 4, 5))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @partial(jit, static_argnums=(3, 4, 5))

def so3_to_wigner_subset_jax(
f: jnp.ndarray,
spins: jnp.ndarray,
Expand Down Expand Up @@ -338,7 +338,7 @@ def s2_to_wigner_subset(
return x * (2.0 * np.pi) ** 2


@partial(jit, static_argnums=(3, 4))
# @partial(jit, static_argnums=(3, 4))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @partial(jit, static_argnums=(3, 4))

def s2_to_wigner_subset_jax(
fs: jnp.ndarray,
spins: jnp.ndarray,
Expand Down
Loading