Deprecate pascal
#285
Merged
Deprecate pascal
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It conflicts with the `pascal` macro in `<Windows.h>`. Yes, they really did define a lowercase-named macro in `<Windows.h>`. As with `PI` (#247), the `#ifndef` should immediately unblock most users, but it's not a long-term solution, because it depends on order-of-includes. Therefore, we also deprecate `pascal` (as with `PI` in #250). I think a good rule of thumb is that deprecated constructs should be deprecated for at least one full minor release cycle, so we'll plan to delete it (along with `PI`) as part of 0.5.0. Fixes #284.
chiphogg
added
the
release notes: 🗑️ lib (deprecation)
geoffviola
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
The workaround seems reasonable.
I couldn't find a way to turn off that macro in minwindef.h. It looks like this workaround is enough for us to compile the all units file on Windows: compiler explorer. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It conflicts with the
pascalmacro in<Windows.h>. Yes, they reallydid define a lowercase-named macro in
<Windows.h>.As with
PI(#247), the#ifndefshould immediately unblock mostusers, but it's not a long-term solution, because it depends on
order-of-includes. Therefore, we also deprecate
pascal(as withPIin #250). I think a good rule of thumb is that deprecated constructs
should be deprecated for at least one full minor release cycle, so we'll
plan to delete it (along with
PI) as part of 0.5.0.Fixes #284.