Skip to content

Fix iframe interactions #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 14, 2025
Merged

Fix iframe interactions #302

merged 16 commits into from
Nov 14, 2025

Conversation

@thalissonvs
Copy link
Member

@thalissonvs thalissonvs commented Nov 11, 2025

Closes #300

@thalissonvs thalissonvs self-assigned this Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.98592% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pydoll/elements/web_element.py 94.62% 13 Missing ⚠️
pydoll/utils.py 30.76% 9 Missing ⚠️
pydoll/elements/mixins/find_elements_mixin.py 88.52% 7 Missing ⚠️
pydoll/browser/managers/temp_dir_manager.py 86.95% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thalissonvs thalissonvs linked an issue Nov 14, 2025 that may be closed by this pull request
[Bug]: IFrame Tab returned by get_frame() on remote Chrome connection uses WebSocket URL with port "None" and crashes when calling page_source #305
Closed
2 tasks
@thalissonvs
fix: enhance element selection and text extraction for better stability
f3bab8c
@thalissonvs
docs: add a deep dive guide on iframes and execution contexts
1b1e7f4
@thalissonvs
test: add shared pytest fixtures and HTML files for integration tests
001ac11
@thalissonvs
perf: update Chrome options for better memory management and stability
2e588b8
@thalissonvs
fix: ensure temp directory cleanup handles Chromium locked files
140fecf
@thalissonvs
test: add unit tests for WebElement text expression and option checks
788cc80
@thalissonvs
fix: remove unnecessary retry_times parameter in file processing
2bfbbe1
@thalissonvs
test: refactor error handling to log permission errors without raising
8193360
@thalissonvs
fix: enhance error handling for locked files on Windows systems
1021917
@thalissonvs
fix: adjust sleep duration for Windows and enhance temp dir cleanup
3b4959c
@thalissonvs
fix: continue cleanup process if temporary directory still exists
560aa49
@thalissonvs thalissonvs linked an issue Nov 14, 2025 that may be closed by this pull request
[Feature] Add static HTML test pages for deterministic integration testing #212
Closed
@thalissonvs thalissonvs merged commit 0b3d5f2 into main Nov 14, 2025
27 of 29 checks passed
@thalissonvs thalissonvs deleted the fix/iframes branch November 14, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thalissonvs thalissonvs

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@thalissonvs