Skip to content

Fix iframe interactions #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 14, 2025
Merged

Fix iframe interactions #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a5a5577
fix: change way to interact with iframes
thalissonvs Nov 11, 2025
04662f5
tests: add tests for the new methods
thalissonvs Nov 11, 2025
10e1ca2
docs: update documentation about iframes
thalissonvs Nov 11, 2025
82e6c80
fix: handle oopif targets
thalissonvs Nov 13, 2025
f5e096a
refactor: refactor iframe context handling in FindElementsMixin class
thalissonvs Nov 13, 2025
f3bab8c
fix: enhance element selection and text extraction for better stability
thalissonvs Nov 14, 2025
1b1e7f4
docs: add a deep dive guide on iframes and execution contexts
thalissonvs Nov 14, 2025
001ac11
test: add shared pytest fixtures and HTML files for integration tests
thalissonvs Nov 14, 2025
2e588b8
perf: update Chrome options for better memory management and stability
thalissonvs Nov 14, 2025
140fecf
fix: ensure temp directory cleanup handles Chromium locked files
thalissonvs Nov 14, 2025
788cc80
test: add unit tests for WebElement text expression and option checks
thalissonvs Nov 14, 2025
2bfbbe1
fix: remove unnecessary retry_times parameter in file processing
thalissonvs Nov 14, 2025
8193360
test: refactor error handling to log permission errors without raising
thalissonvs Nov 14, 2025
1021917
fix: enhance error handling for locked files on Windows systems
thalissonvs Nov 14, 2025
3b4959c
fix: adjust sleep duration for Windows and enhance temp dir cleanup
thalissonvs Nov 14, 2025
560aa49
fix: continue cleanup process if temporary directory still exists
thalissonvs Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/en/deep-dive/architecture/tab-domain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ except KeyError:
raise TopLevelTargetRequired(...) # Guide users to WebElement.take_screenshot()
```

**Design implication:** IFrame tabs (created via `get_frame()`) inherit all Tab methods but screenshots fail by design. Alternative: `WebElement.take_screenshot()` works for iframe content.
**Design implication:** Historically, Pydoll created dedicated Tab instances for iframes. The new model keeps iframe interaction inside `WebElement`, so screenshots and other helpers should target elements within the frame (for example, `await iframe_element.find(...).take_screenshot()`).

**PDF Generation:** `Page.printToPDF` returns base64-encoded data. Pydoll abstracts file I/O, but underlying data is always base64 (CDP spec).

Expand Down
Loading
Loading