-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add S3 enhanced mode #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c4a7154
feat: add S3 enhanced mode
tmalali-coder 4f2b6cb
Update documentation for task_mode parameter
tmalali-coder fbeefad
Fix provider version in documentation
tmalali-coder f6bf4ee
feat: adding enhanced mode to cross account
tmalali-coder 6e5c596
fix: adding documentation and checks
tmalali-coder dd66d4a
Fix markdown linting and update provider version requirements
tmalali-coder 3a66daa
Fix markdown linting
tmalali-coder 3a2b69f
fix: adding checks and documentation
tmalali-coder 5f3f2ef
fix: adding checks and documentation
tmalali-coder 80f8679
feat:fixing terraform-docs
tmalali-coder b56bdd1
fix: adding detail to doc
tmalali-coder 207d661
fix: adding detail to doc and main.tf
tmalali-coder bf848d4
fix: adding detail about configuring object_tags
tmalali-coder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| output "s3_locations" { | ||
| value = aws_datasync_location_s3.s3_location | ||
| value = aws_datasync_location_s3.s3_location | ||
| description = "DataSync S3 Location ARN" | ||
| } | ||
|
|
||
| output "efs_locations" { | ||
| value = aws_datasync_location_efs.efs_location | ||
| value = aws_datasync_location_efs.efs_location | ||
| description = "DataSync EFS Location ARN" | ||
| } | ||
|
|
||
| output "datasync_role_arn" { | ||
| value = { for k, role in aws_iam_role.datasync_role_s3 : k => role.arn } | ||
| value = { for k, role in aws_iam_role.datasync_role_s3 : k => role.arn } | ||
| description = "DataSync Task ARN" | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmalali-coder I can't see the check block that you mentioned adding to the module to make sure that
object_tagsaren't set to"PRESERVE"andverify_modeisn't set to"POINT_IN_TIME_CONSISTENT"when using enhanced mode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed the commit with the
object_tags. I am updating that now.verify_modeis in the variables.tf file.