feat: Add flags to optionally disable DCGM Exporter, Neuron Monitor, and Windows resources #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKamJi98
commented
Apr 10, 2025
There was a problem hiding this comment.
This PR introduces optional flags to disable DCGM Exporter, Neuron Monitor, and Windows-specific CloudWatch Agent components in the Helm chart.
The goal is to make the chart more flexible across environments where those components are not needed.
Please let me know if any changes are required or if you'd like additional test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change introduces new Helm chart flags:
.Values.dcgmExporter.enabled.Values.neuronMonitor.enabled.Values.windows.enabledBy setting them to
false, undesired resources (DCGM Exporter, Neuron Monitor, Windows) are not deployed, thereby preventing unnecessary warnings in logs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.