Skip to content

feat: Add flags to optionally disable DCGM Exporter, Neuron Monitor, and Windows resources #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add flags to optionally disable DCGM Exporter, Neuron Monitor, and Windows resources #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
901c247
feat: add flags to disable dcgm-exporter, neuron-monitor, and windows…
KKamJi98 Mar 31, 2025
d4423d7
feat: add flags to disable dcgm-exporter, neuron-monitor, and windows…
KKamJi98 Mar 31, 2025
cce6634
feat: add flags to disable dcgm-exporter, neuron-monitor, and windows…
KKamJi98 Mar 31, 2025
8178067
Update RELEASE_NOTES
KKamJi98 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions RELEASE_NOTES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
========================================================================
amazon-cloudwatch-observability v3.3.0 (2025-04-01)
========================================================================
New Features:
* Introduce optional flags in Helm chart to disable DCGM Exporter, Neuron Monitor, and Windows resources (#190):
- `.Values.dcgmExporter.enabled`
- `.Values.neuronMonitor.enabled`
- `.Values.windows.enabled`
This allows users to prevent undesired resource deployments and related warning logs.

Enhancements:
* No additional enhancements.

Bug Fixes:
* No additional bug fixes.

=======================================================================
amazon-cloudwatch-observability v3.2.0 (2025-02-04)
========================================================================
Expand Down
4 changes: 3 additions & 1 deletion charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.dcgmExporter.enabled }}
apiVersion: cloudwatch.aws.amazon.com/v1alpha1
kind: DcgmExporter
metadata:
Expand Down Expand Up @@ -73,4 +74,5 @@ spec:
key_file: /etc/amazon-cloudwatch-observability-dcgm-cert/server.key
{{- with .Values.tolerations }}
tolerations: {{- toYaml . | nindent 2}}
{{- end }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.dcgmExporter.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
Expand All @@ -10,3 +11,4 @@ rules:
resources: ["configmaps"]
resourceNames: ["{{ .Values.dcgmExporter.configmap }}"]
verbs: ["get"]
{{- end }}
2 changes: 2 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.dcgmExporter.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
Expand All @@ -13,3 +14,4 @@ subjects:
- kind: ServiceAccount
name: {{ template "dcgm-exporter.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
{{- end }}
4 changes: 3 additions & 1 deletion charts/amazon-cloudwatch-observability/templates/linux/neuron-monitor-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.neuronMonitor.enabled }}
apiVersion: cloudwatch.aws.amazon.com/v1alpha1
kind: NeuronMonitor
metadata:
Expand Down Expand Up @@ -95,4 +96,5 @@ spec:
}
{{- with .Values.tolerations }}
tolerations: {{- toYaml . | nindent 2}}
{{- end }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/neuron-monitor-exporter-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.neuronMonitor.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
Expand All @@ -10,3 +11,4 @@ rules:
resources: ["configmaps"]
resourceNames: ["{{ .Values.neuronMonitor.configmap }}"]
verbs: ["get"]
{{- end }}
2 changes: 2 additions & 0 deletions .../amazon-cloudwatch-observability/templates/linux/neuron-monitor-exporter-rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.neuronMonitor.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
Expand All @@ -13,3 +14,4 @@ subjects:
- kind: ServiceAccount
name: {{ include "neuron-monitor.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
{{- end }}
2 changes: 1 addition & 1 deletion ...bservability/templates/windows/cloudwatch-agent-windows-container-insights-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.agent.enabled }}
{{- if .Values.windows.enabled }}
{{- $clusterName := .Values.clusterName | required ".Values.clusterName is required." -}}
{{- $region := .Values.region | required ".Values.region is required." -}}
{{- $config := `{"logs":{"metrics_collected":{"kubernetes":{"enhanced_container_insights":true}}}}` | fromJson -}}
Expand Down
2 changes: 1 addition & 1 deletion ...amazon-cloudwatch-observability/templates/windows/cloudwatch-agent-windows-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.agent.enabled }}
{{- if .Values.windows.enabled }}
{{- $clusterName := .Values.clusterName | required ".Values.clusterName is required." -}}
{{- $region := .Values.region | required ".Values.region is required." -}}
{{- $config := `{"logs":{"metrics_collected":{"application_signals":{}}},"traces":{"traces_collected":{"application_signals":{}}}}` | fromJson -}}
Expand Down
2 changes: 1 addition & 1 deletion charts/amazon-cloudwatch-observability/templates/windows/fluent-bit-windows-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.containerLogs.enabled }}
{{- if .Values.windows.enabled }}
apiVersion: v1
kind: ConfigMap
metadata:
Expand Down
2 changes: 1 addition & 1 deletion charts/amazon-cloudwatch-observability/templates/windows/fluent-bit-windows-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.containerLogs.enabled }}
{{- if .Values.windows.enabled }}
{{- $clusterName := .Values.clusterName | required ".Values.clusterName is required." -}}
{{- $region := .Values.region | required ".Values.region is required." -}}
apiVersion: apps/v1
Expand Down
4 changes: 4 additions & 0 deletions charts/amazon-cloudwatch-observability/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,7 @@ agent:
prometheusCR:
enabled: false
dcgmExporter:
enabled: true
name:
image:
repository: dcgm-exporter
Expand Down Expand Up @@ -1424,6 +1425,7 @@ dcgmExporter:
serviceAccount:
name: # override exporter service account name
neuronMonitor:
enabled: true
name:
image:
repository: neuron-monitor
Expand Down Expand Up @@ -1451,3 +1453,5 @@ neuronMonitor:
- SYS_ADMIN
serviceAccount:
name: # override exporter service account name
windows:
enabled: true